Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: content/browser/loader/detachable_resource_handler.cc

Issue 2673453002: Fix DetachableResourceHandler when OnResponseCompleted is deferred. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/detachable_resource_handler.cc
diff --git a/content/browser/loader/detachable_resource_handler.cc b/content/browser/loader/detachable_resource_handler.cc
index 85ac2d386069f9223dd693156624c04b662379ea..15ab8c3adf98798b3c74a306825bf22f7f1fb134 100644
--- a/content/browser/loader/detachable_resource_handler.cc
+++ b/content/browser/loader/detachable_resource_handler.cc
@@ -226,7 +226,9 @@ void DetachableResourceHandler::OnResponseCompleted(
is_finished_ = true;
- next_handler_->OnResponseCompleted(status, std::move(controller));
+ HoldController(std::move(controller));
+ next_handler_->OnResponseCompleted(status,
+ base::MakeUnique<Controller>(this));
}
void DetachableResourceHandler::OnDataDownloaded(int bytes_downloaded) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698