Issue 2673393002: Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2673393002: Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration. (Closed)

Created:
3 years, 10 months ago by vasilii

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration. BUG=687266 Review-Url: https://codereview.chromium.org/2666043004 Cr-Commit-Position: refs/heads/master@{#447502} (cherry picked from commit aeb4ece778671ee806942e7fe4ba57431ebea692) Review-Url: https://codereview.chromium.org/2673393002 . Cr-Commit-Position: refs/branch-heads/2987@{#322} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/fa4a421402e98756855f8c8a229aefea944d9637

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -3 lines)			Patch
M	chrome/browser/password_manager/password_manager_browsertest.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download
M	components/password_manager/core/browser/http_password_migrator.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	components/password_manager/core/browser/http_password_migrator_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

vasilii

3 years, 10 months ago (2017-02-06 13:39:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa4a421402e98756855f8c8a229aefea944d9637.