Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: components/password_manager/core/browser/http_password_migrator_unittest.cc

Issue 2673393002: Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/http_password_migrator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/http_password_migrator_unittest.cc
diff --git a/components/password_manager/core/browser/http_password_migrator_unittest.cc b/components/password_manager/core/browser/http_password_migrator_unittest.cc
index ab7bb551c1e9df6ac710b3346de57ea6b38a9650..e536f10a2fd3a02bbd274c4a1fef6491fcf8fae9 100644
--- a/components/password_manager/core/browser/http_password_migrator_unittest.cc
+++ b/components/password_manager/core/browser/http_password_migrator_unittest.cc
@@ -28,7 +28,7 @@ PasswordForm CreateTestForm() {
PasswordForm form;
form.origin = GURL(kTestHttpURL);
form.signon_realm = form.origin.spec();
- form.action = GURL(kTestHttpURL);
+ form.action = GURL("https://example.org/action.html");
form.username_value = base::ASCIIToUTF16("user");
form.password_value = base::ASCIIToUTF16("password");
return form;
@@ -116,7 +116,6 @@ TEST_F(HttpPasswordMigratorTest, FullStore) {
PasswordForm expected_form = form;
expected_form.origin = GURL(kTestHttpsURL);
expected_form.signon_realm = expected_form.origin.spec();
- expected_form.action = expected_form.origin;
EXPECT_CALL(store(), AddLogin(expected_form));
EXPECT_CALL(consumer(), ProcessForms(ElementsAre(Pointee(expected_form))));
« no previous file with comments | « components/password_manager/core/browser/http_password_migrator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698