Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration.

Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration.

BUG=687266
Review-Url: https://codereview.chromium.org/2666043004
Cr-Commit-Position: refs/heads/master@{#447502}
Committed: https://chromium.googlesource.com/chromium/src/+/aeb4ece778671ee806942e7fe4ba57431ebea692

[vasilii, 2017-01-31 19:21:25]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 19:21:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-01-31 19:22:37]

vasilii@chromium.org changed reviewers:
+ jdoerrie@chromium.org

[vasilii, 2017-01-31 19:22:38]

Hi Jan,

please review.

[commit-bot: I haz the power, 2017-01-31 19:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:42:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vasilii, 2017-02-01 11:00:10]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 11:00:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 11:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 11:19:43]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vasilii, 2017-02-01 11:40:10]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 11:40:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-02-01 11:59:28]

LGTM % Nit.

https://codereview.chromium.org/2666043004/diff/40001/components/password_man...
File components/password_manager/core/browser/http_password_migrator.cc (right):

https://codereview.chromium.org/2666043004/diff/40001/components/password_man...
components/password_manager/core/browser/http_password_migrator.cc:50: if
(!form->action.SchemeIs(url::kHttpsScheme))
Nit: Consider adding a comment explaining why we check this.

[vasilii, 2017-02-01 12:14:44]

https://codereview.chromium.org/2666043004/diff/40001/components/password_man...
File components/password_manager/core/browser/http_password_migrator.cc (right):

https://codereview.chromium.org/2666043004/diff/40001/components/password_man...
components/password_manager/core/browser/http_password_migrator.cc:50: if
(!form->action.SchemeIs(url::kHttpsScheme))
On 2017/02/01 11:59:28, jdoerrie wrote:
> Nit: Consider adding a comment explaining why we check this.

Done.

[vasilii, 2017-02-01 12:14:49]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2017-02-01 12:14:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdoerrie@chromium.org
Link to the patchset: https://codereview.chromium.org/2666043004/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2017-02-01 12:15:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 12:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 12:15:05]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dullweber, 2017-02-01 12:47:28]

lgtm

[vasilii, 2017-02-01 12:47:33]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-02-01 12:47:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 12:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 12:47:46]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[kolos1, 2017-02-01 12:50:23]

LGTM

[vasilii, 2017-02-01 12:50:39]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-02-01 12:50:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 13:38:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485953439007690,
"parent_rev": "1a2f7ebbdaadf59b17dee4ba989338c75316778f", "commit_rev":
"aeb4ece778671ee806942e7fe4ba57431ebea692"}

[commit-bot: I haz the power, 2017-02-01 13:39:34]

Description was changed from

==========
Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration.

BUG=687266
==========

to

==========
Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration.

BUG=687266

Review-Url: https://codereview.chromium.org/2666043004
Cr-Commit-Position: refs/heads/master@{#447502}
Committed:
https://chromium.googlesource.com/chromium/src/+/aeb4ece778671ee806942e7fe4ba...
==========

[commit-bot: I haz the power, 2017-02-01 13:39:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aeb4ece778671ee806942e7fe4ba...