[ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags.

[ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags.

BUG=v8:5917
Review-Url: https://codereview.chromium.org/2673383002
Cr-Commit-Position: refs/heads/master@{#42982}
Committed: https://chromium.googlesource.com/v8/v8/+/ef4e2ab7bd75eae60e8ab2e7757e0772c4d00efd

[Igor Sheludko, 2017-02-06 11:16:56]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-02-06 11:17:04]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 11:17:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-02-06 11:18:24]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org, mstarzinger@chromium.org, mvstanton@chromium.org

[Igor Sheludko, 2017-02-06 11:18:25]

Benedikt, PTAL @ CS
Michi, PTAL @ TF, I and heap
Michael, PTAL at the whole CL

[Benedikt Meurer, 2017-02-06 11:25:04]

LGTM on crankshaft.

[commit-bot: I haz the power, 2017-02-06 11:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 11:45:50]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-02-06 13:26:18]

LGTM on the plumbing, didn't look at IC internals.

https://codereview.chromium.org/2673383002/diff/20001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):

https://codereview.chromium.org/2673383002/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.h:327: // Returns language mode encoded into kind of
given slot.
nit: s/language mode/typeof mode/

[Igor Sheludko, 2017-02-06 16:18:02]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 16:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 16:44:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:44:27]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-02-07 09:01:09]

Fantastic, LGTM!

[Igor Sheludko, 2017-02-07 09:01:39]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2017-02-07 09:01:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2673383002/#ps40001
(title: "Addressed comments and added check to FCG")

[commit-bot: I haz the power, 2017-02-07 09:01:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 09:03:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486458099615110,
"parent_rev": "e34f53662055c57f15f03b375cb59ea8772596fe", "commit_rev":
"ef4e2ab7bd75eae60e8ab2e7757e0772c4d00efd"}

[commit-bot: I haz the power, 2017-02-07 09:03:22]

Description was changed from

==========
[ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's
flags.

BUG=v8:5917
==========

to

==========
[ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's
flags.

BUG=v8:5917

Review-Url: https://codereview.chromium.org/2673383002
Cr-Commit-Position: refs/heads/master@{#42982}
Committed:
https://chromium.googlesource.com/v8/v8/+/ef4e2ab7bd75eae60e8ab2e7757e0772c4d...
==========

[commit-bot: I haz the power, 2017-02-07 09:03:23]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ef4e2ab7bd75eae60e8ab2e7757e0772c4d...