src/type-feedback-vector-inl.h - Issue 2673383002: [ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-feedback-vector-inl.h

Issue 2673383002: [ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags. (Closed)

Patch Set: Addressed comments and added check to FCG Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/type-feedback-vector-inl.h

diff --git a/src/type-feedback-vector-inl.h b/src/type-feedback-vector-inl.h

index 43f055b7bd6f8af19a4b67e6fc9bc1eabb856b62..3c6319018671fa2836e2135050cde836828715c1 100644

--- a/src/type-feedback-vector-inl.h

+++ b/src/type-feedback-vector-inl.h

@@ -61,7 +61,8 @@ int TypeFeedbackMetadata::GetSlotSize(FeedbackVectorSlotKind kind) {

case FeedbackVectorSlotKind::CALL_IC:

case FeedbackVectorSlotKind::LOAD_IC:

- case FeedbackVectorSlotKind::LOAD_GLOBAL_IC:

+ case FeedbackVectorSlotKind::LOAD_GLOBAL_INSIDE_TYPEOF_IC:

+ case FeedbackVectorSlotKind::LOAD_GLOBAL_NOT_INSIDE_TYPEOF_IC:

case FeedbackVectorSlotKind::KEYED_LOAD_IC:

case FeedbackVectorSlotKind::STORE_SLOPPY_IC:

case FeedbackVectorSlotKind::STORE_STRICT_IC:

@@ -174,7 +175,8 @@ void TypeFeedbackVector::ComputeCounts(int* with_type_info, int* generic,

switch (kind) {