src/objects-printer.cc - Issue 2673383002: [ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-printer.cc

Issue 2673383002: [ic] Encode LoadGlobalIC's typeof mode in slot kind instead of code object's flags. (Closed)

Patch Set: Addressed comments and added check to FCG Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-printer.cc

diff --git a/src/objects-printer.cc b/src/objects-printer.cc

index 998e8e13d7696ab442cbfd72cfbbe1d2f383b5c6..cdff8f85bea09efa0b50ec517c7fdefd5dbcde64 100644

--- a/src/objects-printer.cc

+++ b/src/objects-printer.cc

@@ -761,7 +761,8 @@ void TypeFeedbackVector::TypeFeedbackVectorPrint(std::ostream& os) { // NOLINT

os << Code::ICState2String(nexus.StateFromFeedback());

break;

}

- case FeedbackVectorSlotKind::LOAD_GLOBAL_IC: {

+ case FeedbackVectorSlotKind::LOAD_GLOBAL_INSIDE_TYPEOF_IC:

+ case FeedbackVectorSlotKind::LOAD_GLOBAL_NOT_INSIDE_TYPEOF_IC: {

LoadGlobalICNexus nexus(this, slot);

os << Code::ICState2String(nexus.StateFromFeedback());

break;

« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »