Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2673283002: Added CSSPropertyAPI.h.tmpl to generate CSSPropertyAPI.h. (Closed)

Created:
3 years, 10 months ago by aazzam
Modified:
3 years, 7 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added CSSPropertyAPI.h.tmpl to generate CSSPropertyAPI.h. Added CSSPropertyAPI.h.tmpl and modified make_css_property_apis.py to generate CSSPropertyAPI.h. As a result of this, new methods added to the API no longer need to be added to CSSPropertyAPI.h - the methods in this file correspond to the methods defined in CSSPropertyAPIMethods.json5. BUG=668012

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : deleted CSSPropertyAPI.h #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Total comments: 2

Patch Set 6 : Added comment field to CSSPropertyAPIMethods.json5 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -82 lines) Patch
M third_party/WebKit/Source/build/scripts/make_css_property_apis.py View 1 2 3 4 5 2 chunks +11 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/build/scripts/scripts.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl View 1 2 3 4 5 1 chunk +8 lines, -20 lines 1 comment Download
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5 View 1 2 3 4 5 1 chunk +15 lines, -3 lines 2 comments Download

Depends on Patchset:

Issue 2669243009 Patch 220001

Dependent Patchsets:

Issue 2684353002 Patch 40001

Messages

Total messages: 9 (6 generated)
aazzam
PTAL sasha :)
3 years, 10 months ago (2017-02-08 03:12:52 UTC) #5
sashab
https://codereview.chromium.org/2673283002/diff/80001/third_party/WebKit/Source/build/scripts/make_css_property_apis.py File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right): https://codereview.chromium.org/2673283002/diff/80001/third_party/WebKit/Source/build/scripts/make_css_property_apis.py#newcode91 third_party/WebKit/Source/build/scripts/make_css_property_apis.py:91: 'api_methods': self.all_api_methods, all_api_methods https://codereview.chromium.org/2673283002/diff/80001/third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl File third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl (right): https://codereview.chromium.org/2673283002/diff/80001/third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl#newcode35 third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl:35: ...
3 years, 10 months ago (2017-02-10 01:23:20 UTC) #8
sashab
3 years, 10 months ago (2017-02-10 02:47:09 UTC) #9 
LGTM add TODOs for:
- wrapping description
- removing brackets from parameters, or changing to list

https://codereview.chromium.org/2673283002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right):

https://codereview.chromium.org/2673283002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:49:
self.all_api_methods[api_method['name']] = ApiMethod(
Add TODO - wrap comment to 72 chars, will do in follow-up patch

https://codereview.chromium.org/2673283002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl
(right):

https://codereview.chromium.org/2673283002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl:36: {%
for comment_line in all_api_methods[api_method_name].comment %}
Now not needed

https://codereview.chromium.org/2673283002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
(right):

https://codereview.chromium.org/2673283002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:32:
comment: {
Rename to 'description'

https://codereview.chromium.org/2673283002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:42:
comment: ["Parses a single CSS property and returns the corresponding CSSValue.
If the", " input is invalid it returns nullptr."],
Change comment to single string

Powered by Google App Engine
This is Rietveld 408576698