Added CSSPropertyAPIMethods.json5 which defines all API methods.

Added CSSPropertyAPIMethods.json5 which defines all API methods.

Adds CSSPropertyAPIMethods.json5, which defines all methods in
CSSPropertyAPI.h. Methods are defined by name and function
definition.

This is so that when methods are added to the API, their
definitions only need to be added in this file, rather than
several places in the code.

This patch:
- Adds the CSSPropertyAPIMethods.json5 file.
- Changes make_css_property_apis.py so that it can take two files
  as input (CSSProperties.json5 and CSSPropertyAPIMethods.json5).
- Modifies the CSSPropertyAPIFiles.h.tmpl template to take this as
  input, so that it doesn't need to be modified whenever methods
  are added to the API.
- Modifies CSSPropertyDescriptor.cpp.tmpl to take this as input.

BUG=668012

[aazzam, 2017-02-08 02:55:34]

Description was changed from

==========
Added CSSPropertyAPIMethods.json5 -- draft
==========

to

==========
Added CSSPropertyAPIMethods.json5 which defines all API methods.

Adds CSSPropertyAPIMethods.json5, which defines all methods in
CSSPropertyAPI.h. Methods are defined by name and function
definition.
==========

[aazzam, 2017-02-08 03:02:21]

Description was changed from

==========
Added CSSPropertyAPIMethods.json5 which defines all API methods.

Adds CSSPropertyAPIMethods.json5, which defines all methods in
CSSPropertyAPI.h. Methods are defined by name and function
definition.
==========

to

==========
Added CSSPropertyAPIMethods.json5 which defines all API methods.

Adds CSSPropertyAPIMethods.json5, which defines all methods in
CSSPropertyAPI.h. Methods are defined by name and function
definition.

This is so that when methods are added to the API, their
definitions only need to be added in this file, rather than
several places in the code.

This patch:
- Adds the CSSPropertyAPIMethods.json5 file.
- Changes make_css_property_apis.py so that it can take two files
  as input (CSSProperties.json5 and CSSPropertyAPIMethods.json5).
- Modifies the CSSPropertyAPIFiles.h.tmpl template to take this as
  input, so that it doesn't need to be modified whenever methods
  are added to the API.
- Modifies CSSPropertyDescriptor.cpp.tmpl to take this as input.

BUG=668012
==========

[aazzam, 2017-02-08 03:02:33]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-02-08 03:02:34]

ptal sasha! :)

[aazzam, 2017-02-08 03:04:34]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 03:04:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 03:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 03:15:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-02-08 04:00:03]

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right):

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:32:
self.css_properties = CSSProperties([json5_file_paths.pop(0)])
CSSProperties -> StyleBuilderWriter

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:33:
self.css_property_api_methods =
Json5File.load_from_files([json5_file_paths.pop()], {}, {})
Replace .pop() with actual indices, eg [0] and [1]

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:39: ApiMethod
= namedtuple('ApiMethod', ('definition', 'name', 'classnames'))
This is a tuple defining each api method and its definition and the classes its
implemented in

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:40:
self.api_methods_implemented_in = []
A list of all the API methods

self.all_api_methods = {}
name -> ApiMethod(definition, classnames)

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:43:
properties_method_is_implemented_in = []
classnames_method_is_implemented_in = []

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:52: 
# Build ordered, complete list of api methods for each api_class
for property:
  property['api_methods']
  # string if method implemented, False if not, order matters
  api_class?['api_methods_full'] = []
  for api_method in self.all_api_methods:
    if api_method in property['api_methods']:
      property['api_methods_full'].append(api_method)
    else:
      property['api_methods_full'].append(False)

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl
(right):

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl:18:
{% for api_method in api_methods if api_classname in api_method['classnames'] %}
{% for api_method_name in property['api_methods'] %}

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl:19:
{{api_method['definition']}}
self.all_api_methods[api_method_name]['definition']

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl
(right):

https://codereview.chromium.org/2669243009/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl:26:
{% for api_method in api_methods if api_class.classname in
api_method['classnames'] %}
for api_method in api_class['api_methods_full'] if api_method != False

else

[aazzam, 2017-02-09 04:20:29]

ptal sasha :)

[sashab, 2017-02-09 04:36:28]

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right):

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:48: # Stores
an ORDERED list of all API method names.
This must match the order they appear in the Descriptor object.

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:60:
self.methods_for_class[classname].extend(property['api_methods'])
+=

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:79:
'methods_for_class': self.methods_for_class,
Delete methods_for_class

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:88:
'methods_for_class': self.methods_for_class[api_classname],
Change dictionary from methods_for_class -> methods_for_classes

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl
(right):

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl:27:
{% if api_method_name in methods_for_class[api_class.classname] %}
{% if api_method_name in api_class.methods_for_class %}

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
(right):

https://codereview.chromium.org/2669243009/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:22:
name: "parseSingleValue",
Fix indentation

[aazzam, 2017-02-09 04:44:37]

fixed changes, ptal sasha :)

[sashab, 2017-02-09 04:47:08]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[sashab, 2017-02-09 04:57:51]

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right):

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:33:
self.css_property_api_methods = Json5File.load_from_files([json5_file_paths[1]],
{}, {})
#TODO(azzaam): Move the logic for loading CSSPropertyAPIMethods.json5 into a new
class APIMethodsWriter().

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:50:
self.all_api_method_names = [api_method['name'] for api_method in
self.css_property_api_methods.name_dictionaries]
Build this up in the previous for loop, rather than using the list
comprehension.

Also, to emphasize ordered, make it non-caps and rename this to
ordered_api_method_names

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:54: # Map of
API classname to list of methods implemented in the API.
# Map of API classname to list of methods implemented by that class.

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
(right):

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:23:
signature: "static const CSSValue* parseSingleValue(CSSParserTokenRange&, const
CSSParserContext*);",
We should make these all consistent, ie:
- no static keyword
- no trailing comma

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:25: },
If we had:


		{
		  name: "parseSingleValue",
      return_type: "const CSSValue*",
      parameters: "(CSSParserTokenRange&, const CSSParserContext*)",
		},


We could generate the signature and function ptr.

[aazzam, 2017-02-09 23:10:12]

ptal sasha :)

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right):

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:33:
self.css_property_api_methods = Json5File.load_from_files([json5_file_paths[1]],
{}, {})
On 2017/02/09 at 04:57:51, sashab wrote:
> #TODO(azzaam): Move the logic for loading CSSPropertyAPIMethods.json5 into a
new class APIMethodsWriter().

done :)

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:50:
self.all_api_method_names = [api_method['name'] for api_method in
self.css_property_api_methods.name_dictionaries]
On 2017/02/09 at 04:57:51, sashab wrote:
> Build this up in the previous for loop, rather than using the list
comprehension.
> 
> Also, to emphasize ordered, make it non-caps and rename this to
ordered_api_method_names

done :)

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:54: # Map of
API classname to list of methods implemented in the API.
On 2017/02/09 at 04:57:51, sashab wrote:
> # Map of API classname to list of methods implemented by that class.

added :)

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
(right):

https://codereview.chromium.org/2669243009/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:25: },
On 2017/02/09 at 04:57:51, sashab wrote:
> If we had:
> 
> 
> 		{
> 		  name: "parseSingleValue",
>       return_type: "const CSSValue*",
>       parameters: "(CSSParserTokenRange&, const CSSParserContext*)",
> 		},
> 
> 
> We could generate the signature and function ptr.

done :) I've put the logic for combining the strings in the .py file, do you
think they should go in the .tmpl file instead? let me know what you think :)

[sashab, 2017-02-10 00:58:34]

https://codereview.chromium.org/2669243009/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right):

https://codereview.chromium.org/2669243009/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:30:
#TODO(aazzam): Move the logic for loading CSSPropertyAPIMethods.json5 into a new
class APIMethodsWriter().
# space after hash

https://codereview.chromium.org/2669243009/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:48:
function_ptr = api_method['return_type'] + " (*" + api_method['name'] + ")" +
api_method['parameters']
Move this to tmpl

https://codereview.chromium.org/2669243009/diff/160001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl
(right):

https://codereview.chromium.org/2669243009/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl:19:
{% for api_methods in ordered_api_method_names %}
api_methods -> api_method

https://codereview.chromium.org/2669243009/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
(right):

https://codereview.chromium.org/2669243009/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:10:
return_type: {
Add comments for these

[sashab, 2017-02-10 01:12:43]

lgtm

https://codereview.chromium.org/2669243009/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right):

https://codereview.chromium.org/2669243009/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/make_css_property_apis.py:62:
self.methods_for_classes[classname] += property['api_methods']
Add comment above here:
# For api_classes that contain multiple properties, combine all implemented
properties.
# This list contains duplicate entries, but is only used to check if a method is
implemented for an api_class.

[aazzam, 2017-02-10 01:14:25]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-02-10 01:14:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2669243009/#ps200001
(title: "added comment")

[commit-bot: I haz the power, 2017-02-10 01:14:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 01:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 01:33:24]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[aazzam, 2017-02-10 02:01:30]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 02:02:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:15:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-02-10 03:03:47]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 03:04:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 03:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 03:39:42]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[aazzam, 2017-02-10 04:14:50]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 04:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 04:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 04:43:50]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[aazzam, 2017-02-10 05:28:47]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 05:29:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aazzam, 2017-02-10 05:39:54]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 05:40:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-02-10 05:47:17]

https://codereview.chromium.org/2669243009/diff/280001/third_party/WebKit/Sou...
File third_party/WebKit/Source/build/scripts/scripts.gni (right):

https://codereview.chromium.org/2669243009/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/scripts.gni:29:
make_css_property_api_files = [
Not needed :)

https://codereview.chromium.org/2669243009/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/scripts.gni:145: if
(defined(invoker.in_files)) {
Might not need this if we do += below :)

https://codereview.chromium.org/2669243009/diff/280001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/BUILD.gn (right):

https://codereview.chromium.org/2669243009/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/BUILD.gn:480:
css_properties("make_core_generated_css_property_apis") {
Move back up to where it was before in BUILD.gn

https://codereview.chromium.org/2669243009/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/BUILD.gn:486: in_files = [
in_files += instead?

[commit-bot: I haz the power, 2017-02-10 05:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 05:52:21]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[aazzam, 2017-02-10 05:55:56]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 05:56:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aazzam, 2017-02-10 06:02:16]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 06:02:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 06:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 06:23:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)