Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2684353002: Added CSSPropertyDescriptor.h.tmpl to generate CSSPropertyDescriptor.h. (Closed)

Created:
3 years, 10 months ago by aazzam
Modified:
3 years, 7 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added CSSPropertyDescriptor.h.tmpl to generate CSSPropertyDescriptor.h. Added CSSPropertyDescriptor.h.tmpl and modified make_css_property_apis.py to generate CSSPropertyDescriptor.h. As a result of this, new methods added to the API no longer need to be added to the struct in CSSPropertyDescriptor.h - the function pointers in this file correspond to the methods defined in CSSPropertyAPIMethods.json5. BUG=668012

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 3

Patch Set 3 : renames and comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M third_party/WebKit/Source/build/scripts/make_css_property_apis.py View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/scripts.gni View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.h.tmpl View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h View 1 chunk +0 lines, -25 lines 0 comments Download

Depends on Patchset:

Issue 2673283002 Patch 100001

Messages

Total messages: 4 (1 generated)
aazzam
ptal sasha :)
3 years, 10 months ago (2017-02-09 23:30:27 UTC) #2
sashab
https://codereview.chromium.org/2684353002/diff/20001/third_party/WebKit/Source/build/scripts/make_css_property_apis.py File third_party/WebKit/Source/build/scripts/make_css_property_apis.py (right): https://codereview.chromium.org/2684353002/diff/20001/third_party/WebKit/Source/build/scripts/make_css_property_apis.py#newcode98 third_party/WebKit/Source/build/scripts/make_css_property_apis.py:98: 'ordered_api_method_names': self.ordered_api_method_names, Change to ordered in other patch as ...
3 years, 10 months ago (2017-02-10 01:24:34 UTC) #3
sashab
3 years, 10 months ago (2017-02-10 02:42:23 UTC) #4 
LGTM, please put gen code in a comment so we can see it just for our info

Powered by Google App Engine
This is Rietveld 408576698