Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5

Issue 2673283002: Added CSSPropertyAPI.h.tmpl to generate CSSPropertyAPI.h. (Closed)
Patch Set: Added comment field to CSSPropertyAPIMethods.json5 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5 b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
index d30344ce51a6e36e6e9e5c7812ee7e10cd8ee6c3..e0e62b96846b274232321453a284d13148669bb0 100644
--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
@@ -22,18 +22,30 @@
parameters: {
default: "",
valid_type: "str",
- }
+ },
+
+ // - comment
+ // A string comment describing the API method. This comment will be
+ // placed in the code above the method definition in CSSPropertyAPI.h.
+ // This comment should be defined as a list of strings, each no longer than
+ // 72 chars.
+ comment: {
sashab 2017/02/10 02:47:09 Rename to 'description'
+ default: [],
+ valid_type: "list",
+ },
},
data: [
{
name: "parseSingleValue",
return_type: "const CSSValue*",
- parameters: "(CSSParserTokenRange&, const CSSParserContext*)"
+ parameters: "(CSSParserTokenRange&, const CSSParserContext*)",
+ comment: ["Parses a single CSS property and returns the corresponding CSSValue. If the", " input is invalid it returns nullptr."],
sashab 2017/02/10 02:47:09 Change comment to single string
},
{
name: "parseShorthand",
return_type: "bool",
- parameters: "(bool, CSSParserTokenRange&, const CSSParserContext*)"
+ parameters: "(bool, CSSParserTokenRange&, const CSSParserContext*)",
+ comment: ["Returns true if the property can be parsed as a shorthand."],
},
]
}

Powered by Google App Engine
This is Rietveld 408576698