Do not hide the "Login Not Secure" warning on keystrokes

Do not hide the "Login Not Secure" warning on keystrokes

The AutofillAgent::ShowNotSecureWarning function called HidePopup()
unnecessarily each time it was called. This caused the "Login Not
Secure" popup message to hide and reshow each time the user typed
a key.

Removing this call fixes the problem, and the code still behaves
correctly in the event that autofill suggestions are available or
the password generation popup is showing.

BUG=685769
TEST=From an empty profile, visit a HTTP page that collects passwords
(e.g. http://webdbg.com/test/forms/password.htm) and type in the name
or password fields. Observe the "Login Not Secure" warning message; it
should not flicker as characters are typed.

Review-Url: https://codereview.chromium.org/2666873004
Cr-Commit-Position: refs/heads/master@{#447575}
(cherry picked from commit 3249c30a2d284c39241d2e7371656fe79c825669)

Review-Url: https://codereview.chromium.org/2672823005 .
Cr-Commit-Position: refs/branch-heads/2987@{#294}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/c06f9992e3e6714a812d67b4cdb850d1bc99d567

[estark, 2017-02-03 18:49:27]

Description was changed from

==========
Do not hide the "Login Not Secure" warning on keystrokes

The AutofillAgent::ShowNotSecureWarning function called HidePopup()
unnecessarily each time it was called. This caused the "Login Not
Secure" popup message to hide and reshow each time the user typed
a key.

Removing this call fixes the problem, and the code still behaves
correctly in the event that autofill suggestions are available or
the password generation popup is showing.

BUG=685769

TEST=From an empty profile, visit a HTTP page that collects passwords
(e.g. http://webdbg.com/test/forms/password.htm) and type in the name
or password fields. Observe the "Login Not Secure" warning message; it
should not flicker as characters are typed.

Review-Url: https://codereview.chromium.org/2666873004
Cr-Commit-Position: refs/heads/master@{#447575}
(cherry picked from commit 3249c30a2d284c39241d2e7371656fe79c825669)
==========

to

==========
Do not hide the "Login Not Secure" warning on keystrokes

The AutofillAgent::ShowNotSecureWarning function called HidePopup()
unnecessarily each time it was called. This caused the "Login Not
Secure" popup message to hide and reshow each time the user typed
a key.

Removing this call fixes the problem, and the code still behaves
correctly in the event that autofill suggestions are available or
the password generation popup is showing.

BUG=685769

TEST=From an empty profile, visit a HTTP page that collects passwords
(e.g. http://webdbg.com/test/forms/password.htm) and type in the name
or password fields. Observe the "Login Not Secure" warning message; it
should not flicker as characters are typed.

Review-Url: https://codereview.chromium.org/2666873004
Cr-Commit-Position: refs/heads/master@{#447575}
(cherry picked from commit 3249c30a2d284c39241d2e7371656fe79c825669)

Review-Url: https://codereview.chromium.org/2672823005 .
Cr-Commit-Position: refs/branch-heads/2987@{#294}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/c06f9992e3e6714a812d67b4cdb8...
==========

[estark, 2017-02-03 18:49:28]

Committed patchset #1 (id:1) manually as
c06f9992e3e6714a812d67b4cdb850d1bc99d567 (tree was closed).