Do not hide the "Login Not Secure" warning on keystrokes

Do not hide the "Login Not Secure" warning on keystrokes

The AutofillAgent::ShowNotSecureWarning function called HidePopup()
unnecessarily each time it was called. This caused the "Login Not
Secure" popup message to hide and reshow each time the user typed
a key.

Removing this call fixes the problem, and the code still behaves
correctly in the event that autofill suggestions are available or
the password generation popup is showing.

BUG=685769
TEST=From an empty profile, visit a HTTP page that collects passwords
(e.g. http://webdbg.com/test/forms/password.htm) and type in the name
or password fields. Observe the "Login Not Secure" warning message; it
should not flicker as characters are typed.

Review-Url: https://codereview.chromium.org/2666873004
Cr-Commit-Position: refs/heads/master@{#447575}
Committed: https://chromium.googlesource.com/chromium/src/+/3249c30a2d284c39241d2e7371656fe79c825669

[elawrence, 2017-01-31 20:19:46]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 20:20:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 21:46:43]

Dry run: This issue passed the CQ dry run.

[elawrence, 2017-01-31 22:30:17]

elawrence@chromium.org changed reviewers:
+ sebsg@chromium.org

[elawrence, 2017-01-31 22:30:17]

Can you PTAL at this small change to the ShowNotSecureWarning() logic?

[sebsg, 2017-02-01 19:15:05]

lgtm

[elawrence, 2017-02-01 19:16:16]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-02-01 19:16:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 19:23:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485976576525850, "parent_rev":
"9713b4c9d2c1234bfef097f5af3ebc690be43552", "commit_rev":
"3249c30a2d284c39241d2e7371656fe79c825669"}

[commit-bot: I haz the power, 2017-02-01 19:24:26]

Description was changed from

==========
Do not hide the "Login Not Secure" warning on keystrokes

The AutofillAgent::ShowNotSecureWarning function called HidePopup()
unnecessarily each time it was called. This caused the "Login Not
Secure" popup message to hide and reshow each time the user typed
a key.

Removing this call fixes the problem, and the code still behaves
correctly in the event that autofill suggestions are available or
the password generation popup is showing.

BUG=685769

TEST=From an empty profile, visit a HTTP page that collects passwords
(e.g. http://webdbg.com/test/forms/password.htm) and type in the name
or password fields. Observe the "Login Not Secure" warning message; it
should not flicker as characters are typed.
==========

to

==========
Do not hide the "Login Not Secure" warning on keystrokes

The AutofillAgent::ShowNotSecureWarning function called HidePopup()
unnecessarily each time it was called. This caused the "Login Not
Secure" popup message to hide and reshow each time the user typed
a key.

Removing this call fixes the problem, and the code still behaves
correctly in the event that autofill suggestions are available or
the password generation popup is showing.

BUG=685769

TEST=From an empty profile, visit a HTTP page that collects passwords
(e.g. http://webdbg.com/test/forms/password.htm) and type in the name
or password fields. Observe the "Login Not Secure" warning message; it
should not flicker as characters are typed.

Review-Url: https://codereview.chromium.org/2666873004
Cr-Commit-Position: refs/heads/master@{#447575}
Committed:
https://chromium.googlesource.com/chromium/src/+/3249c30a2d284c39241d2e737165...
==========

[commit-bot: I haz the power, 2017-02-01 19:24:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3249c30a2d284c39241d2e737165...