Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 2672823005: Do not hide the "Login Not Secure" warning on keystrokes (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/autofill_agent.h" 5 #include "components/autofill/content/renderer/autofill_agent.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <tuple> 9 #include <tuple>
10 10
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 options.autofill_on_empty_values = true; 570 options.autofill_on_empty_values = true;
571 options.show_full_suggestion_list = true; 571 options.show_full_suggestion_list = true;
572 for (auto element : elements) 572 for (auto element : elements)
573 ShowSuggestions(element, options); 573 ShowSuggestions(element, options);
574 } 574 }
575 575
576 void AutofillAgent::ShowNotSecureWarning( 576 void AutofillAgent::ShowNotSecureWarning(
577 const blink::WebInputElement& element) { 577 const blink::WebInputElement& element) {
578 if (is_generation_popup_possibly_visible_) 578 if (is_generation_popup_possibly_visible_)
579 return; 579 return;
580 HidePopup();
581 password_autofill_agent_->ShowNotSecureWarning(element); 580 password_autofill_agent_->ShowNotSecureWarning(element);
582 is_popup_possibly_visible_ = true; 581 is_popup_possibly_visible_ = true;
583 } 582 }
584 583
585 void AutofillAgent::OnSamePageNavigationCompleted() { 584 void AutofillAgent::OnSamePageNavigationCompleted() {
586 if (last_interacted_form_.isNull()) { 585 if (last_interacted_form_.isNull()) {
587 // If no last interacted form is available (i.e., there is no form tag), 586 // If no last interacted form is available (i.e., there is no form tag),
588 // we check if all the elements the user has interacted with are gone, 587 // we check if all the elements the user has interacted with are gone,
589 // to decide if submission has occurred. 588 // to decide if submission has occurred.
590 if (formless_elements_user_edited_.size() == 0 || 589 if (formless_elements_user_edited_.size() == 0 ||
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 void AutofillAgent::LegacyAutofillAgent::OnDestruct() { 817 void AutofillAgent::LegacyAutofillAgent::OnDestruct() {
819 // No-op. Don't delete |this|. 818 // No-op. Don't delete |this|.
820 } 819 }
821 820
822 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() { 821 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() {
823 if (agent_) 822 if (agent_)
824 agent_->FocusChangeComplete(); 823 agent_->FocusChangeComplete();
825 } 824 }
826 825
827 } // namespace autofill 826 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698