Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2672723003: Converted CRWSessionController to use NavigationItems. (Closed)

Created:
3 years, 10 months ago by kkhorimoto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkl (ping after 24h if needed), Eugene But (OOO till 7-30), net-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converted CRWSessionController to use NavigationItems. This CL introduces scoped and unscoped NavigationItemLists, and are used to store the NavigationItems within CRWSessionController. CRWSessionEntries no longer own their corresponding NavigationItems, and are stored in a map managed by CRWSessionController. The CRWSessionEntry properties have been updated to return NavigationItems, and the CRWSessionController selector names have been updated to refer to NavigationItems rather than CRWSessionEntries. BUG=454984

Patch Set 1 #

Patch Set 2 : test fixes, self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1277 lines, -1095 lines) Patch
M ios/chrome/browser/native_app_launcher/native_app_navigation_util_unittest.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 2 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/crw_session_controller.h View 4 chunks +93 lines, -71 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 15 chunks +435 lines, -332 lines 0 comments Download
M ios/web/navigation/crw_session_controller+private_constructors.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 1 43 chunks +375 lines, -397 lines 0 comments Download
M ios/web/navigation/crw_session_entry.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ios/web/navigation/crw_session_entry.mm View 2 chunks +21 lines, -31 lines 0 comments Download
M ios/web/navigation/crw_session_entry_unittest.mm View 1 2 chunks +15 lines, -24 lines 0 comments Download
A ios/web/navigation/navigation_item_impl_list.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_item_impl_list.mm View 1 chunk +22 lines, -0 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 6 chunks +10 lines, -9 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 18 chunks +151 lines, -151 lines 0 comments Download
M ios/web/navigation/navigation_manager_storage_builder.mm View 6 chunks +16 lines, -18 lines 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 chunk +5 lines, -5 lines 0 comments Download
A ios/web/public/navigation_item_list.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/web/public/navigation_item_list.mm View 1 chunk +17 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 14 chunks +34 lines, -33 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
kkhorimoto
3 years, 10 months ago (2017-02-02 23:13:21 UTC) #2
Eugene But (OOO till 7-30)
This is quite large CL which has safe parts (renaming) and unsaafe parts (changing the ...
3 years, 10 months ago (2017-02-02 23:25:10 UTC) #3
kkhorimoto
3 years, 10 months ago (2017-02-04 00:05:11 UTC) #5
Message was sent while issue was closed.
This CL was split into two smaller ones:

Interface name changes are here:
https://codereview.chromium.org/2671773005/

Logic changes are here:
https://codereview.chromium.org/2672953005/

Powered by Google App Engine
This is Rietveld 408576698