Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2672723003: Converted CRWSessionController to use NavigationItems. (Closed)
Patch Set: test fixes, self review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index eccd6aec3e3b4eb1be2fbcb00a548b2b6b267b3d..bef56fa94a726daa0d51018216ec2bdd64928428 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -632,7 +632,7 @@ void RestoreSession(SessionWindowIOS* window) {
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
// Force the history to update, as it is used to determine grouping.
ASSERT_TRUE([parent navigationManager]);
- [[parent navigationManager]->GetSessionController() commitPendingEntry];
+ [[parent navigationManager]->GetSessionController() commitPendingItem];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
@@ -670,7 +670,7 @@ void RestoreSession(SessionWindowIOS* window) {
parent_params.transition_type = ui::PAGE_TRANSITION_TYPED;
[[parent webController] loadWithParams:parent_params];
ASSERT_TRUE([parent navigationManager]);
- [[parent navigationManager]->GetSessionController() commitPendingEntry];
+ [[parent navigationManager]->GetSessionController() commitPendingItem];
EXPECT_EQ([tab_model_ indexOfTab:parent], 0U);
// Add a new tab. It should be added behind the parent. It should not be added
@@ -715,7 +715,7 @@ void RestoreSession(SessionWindowIOS* window) {
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
// Force the history to update, as it is used to determine grouping.
ASSERT_TRUE([parent navigationManager]);
- [[parent navigationManager]->GetSessionController() commitPendingEntry];
+ [[parent navigationManager]->GetSessionController() commitPendingItem];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698