Index: ios/web/navigation/crw_session_controller_unittest.mm |
diff --git a/ios/web/navigation/crw_session_controller_unittest.mm b/ios/web/navigation/crw_session_controller_unittest.mm |
index a2a9094326d8cbebaef2cd85ae45e91d47dd24e2..cc4f3c8bd0fc32e95e8f0ab0ce2c962f2401ed6c 100644 |
--- a/ios/web/navigation/crw_session_controller_unittest.mm |
+++ b/ios/web/navigation/crw_session_controller_unittest.mm |
@@ -73,25 +73,24 @@ void SetUp() override { |
// Tests session controller state after setting a pending index. |
TEST_F(CRWSessionControllerTest, SetPendingIndex) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
- [session_controller_ setPendingEntryIndex:0]; |
- EXPECT_EQ(0, [session_controller_ pendingEntryIndex]); |
+ [session_controller_ addPendingItem:GURL("http://www.example.com") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
+ [session_controller_ setPendingItemIndex:0]; |
+ EXPECT_EQ(0, [session_controller_ pendingItemIndex]); |
EXPECT_EQ([[session_controller_ entries] lastObject], |
[session_controller_ pendingEntry]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntry) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+TEST_F(CRWSessionControllerTest, addPendingItem) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
EXPECT_EQ(0U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -99,19 +98,17 @@ void SetUp() override { |
[session_controller_ currentURL]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryWithCommittedEntries) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.committed.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+TEST_F(CRWSessionControllerTest, addPendingItemWithCommittedEntries) { |
+ [session_controller_ addPendingItem:GURL("http://www.committed.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -123,42 +120,41 @@ void SetUp() override { |
} |
// Tests that adding a pending entry resets pending entry index. |
-TEST_F(CRWSessionControllerTest, AddPendingEntryWithExisingPendingEntryIndex) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+TEST_F(CRWSessionControllerTest, addPendingItemWithExisingPendingEntryIndex) { |
+ [session_controller_ addPendingItem:GURL("http://www.example.com") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
// Set 0 as pending entry index. |
- [session_controller_ setPendingEntryIndex:0]; |
+ [session_controller_ setPendingItemIndex:0]; |
EXPECT_EQ(GURL("http://www.example.com/"), |
[[session_controller_ pendingEntry] navigationItem]->GetURL()); |
- EXPECT_EQ(0, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(0, [session_controller_ pendingItemIndex]); |
// Add a pending entry, which should drop pending navigation index. |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/1") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/1") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
EXPECT_EQ(GURL("http://www.example.com/1"), |
[[session_controller_ pendingEntry] navigationItem]->GetURL()); |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryOverriding) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+TEST_F(CRWSessionControllerTest, addPendingItemOverriding) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
[session_controller_ |
- addPendingEntry:GURL("http://www.another.url.com") |
+ addPendingItem:GURL("http://www.another.url.com") |
referrer:MakeReferrer("http://www.another.referer.com") |
transition:ui::PAGE_TRANSITION_TYPED |
rendererInitiated:NO]; |
@@ -169,13 +165,12 @@ void SetUp() override { |
[session_controller_ currentURL]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryAndCommit) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+TEST_F(CRWSessionControllerTest, addPendingItemAndCommit) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -186,18 +181,17 @@ void SetUp() override { |
[session_controller_ currentEntry]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryOverridingAndCommit) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+TEST_F(CRWSessionControllerTest, addPendingItemOverridingAndCommit) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
[session_controller_ |
- addPendingEntry:GURL("http://www.another.url.com") |
+ addPendingItem:GURL("http://www.another.url.com") |
referrer:MakeReferrer("http://www.another.referer.com") |
transition:ui::PAGE_TRANSITION_TYPED |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -208,20 +202,19 @@ void SetUp() override { |
[session_controller_ currentEntry]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryAndCommitMultiple) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+TEST_F(CRWSessionControllerTest, addPendingItemAndCommitMultiple) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
[session_controller_ |
- addPendingEntry:GURL("http://www.another.url.com") |
+ addPendingItem:GURL("http://www.another.url.com") |
referrer:MakeReferrer("http://www.another.referer.com") |
transition:ui::PAGE_TRANSITION_TYPED |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(2U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -235,49 +228,46 @@ void SetUp() override { |
[session_controller_ currentEntry]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryAndDiscard) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ discardNonCommittedEntries]; |
+TEST_F(CRWSessionControllerTest, addPendingItemAndDiscard) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ discardNonCommittedItems]; |
EXPECT_EQ(0U, [[session_controller_ entries] count]); |
EXPECT_EQ(nil, [session_controller_ currentEntry]); |
} |
-// Tests discarding pending entry added via |setPendingEntryIndex:| call. |
-TEST_F(CRWSessionControllerTest, SetPendingEntryIndexAndDiscard) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+// Tests discarding pending entry added via |setPendingItemIndex:| call. |
+TEST_F(CRWSessionControllerTest, setPendingItemIndexAndDiscard) { |
+ [session_controller_ addPendingItem:GURL("http://www.example.com") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
- [session_controller_ setPendingEntryIndex:0]; |
+ [session_controller_ setPendingItemIndex:0]; |
EXPECT_TRUE([session_controller_ pendingEntry]); |
- EXPECT_EQ(0, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(0, [session_controller_ pendingItemIndex]); |
- [session_controller_ discardNonCommittedEntries]; |
+ [session_controller_ discardNonCommittedItems]; |
EXPECT_FALSE([session_controller_ pendingEntry]); |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryAndDiscardAndAddAndCommit) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ discardNonCommittedEntries]; |
+TEST_F(CRWSessionControllerTest, addPendingItemAndDiscardAndAddAndCommit) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ discardNonCommittedItems]; |
- [session_controller_ |
- addPendingEntry:GURL("http://www.another.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.another.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -288,20 +278,18 @@ void SetUp() override { |
[session_controller_ currentEntry]); |
} |
-TEST_F(CRWSessionControllerTest, AddPendingEntryAndCommitAndAddAndDiscard) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+TEST_F(CRWSessionControllerTest, addPendingItemAndCommitAndAddAndDiscard) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
- [session_controller_ |
- addPendingEntry:GURL("http://www.another.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ discardNonCommittedEntries]; |
+ [session_controller_ addPendingItem:GURL("http://www.another.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ discardNonCommittedItems]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -313,25 +301,24 @@ void SetUp() override { |
} |
TEST_F(CRWSessionControllerTest, |
- CommitPendingEntryWithoutPendingOrCommittedEntry) { |
- [session_controller_ commitPendingEntry]; |
+ commitPendingItemWithoutPendingOrCommittedEntry) { |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(0U, [[session_controller_ entries] count]); |
EXPECT_EQ(nil, [session_controller_ currentEntry]); |
} |
TEST_F(CRWSessionControllerTest, |
- CommitPendingEntryWithoutPendingEntryWithCommittedEntry) { |
+ commitPendingItemWithoutPendingEntryWithCommittedEntry) { |
// Setup committed entry |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
// Commit pending entry when there is no such one |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -340,33 +327,33 @@ void SetUp() override { |
} |
// Tests that forward entries are discarded after navigation entry is committed. |
-TEST_F(CRWSessionControllerTest, CommitPendingEntryWithExistingForwardEntries) { |
+TEST_F(CRWSessionControllerTest, commitPendingItemWithExistingForwardEntries) { |
// Make 3 entries. |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:YES]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/1") |
- referrer:MakeReferrer("http://www.example.com/b") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:YES]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/2") |
- referrer:MakeReferrer("http://www.example.com/c") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:YES]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:YES]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/1") |
+ referrer:MakeReferrer("http://www.example.com/b") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:YES]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/2") |
+ referrer:MakeReferrer("http://www.example.com/c") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:YES]; |
+ [session_controller_ commitPendingItem]; |
// Go back to the first entry. |
- [session_controller_ goToEntryAtIndex:0]; |
+ [session_controller_ goToItemAtIndex:0]; |
// Create and commit a new pending entry. |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/2") |
- referrer:MakeReferrer("http://www.example.com/c") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:YES]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/2") |
+ referrer:MakeReferrer("http://www.example.com/c") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:YES]; |
+ [session_controller_ commitPendingItem]; |
// All forward entries should go away. |
EXPECT_EQ(2U, [[session_controller_ entries] count]); |
@@ -376,39 +363,39 @@ void SetUp() override { |
} |
// Tests committing pending entry index from the middle. |
-TEST_F(CRWSessionControllerTest, CommitPendingEntryIndex) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/1") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/2") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+TEST_F(CRWSessionControllerTest, commitPendingItemIndex) { |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/1") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/2") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
ASSERT_EQ(3U, [[session_controller_ entries] count]); |
// Go to the middle, and commit first pending entry index. |
- [session_controller_ goToEntryAtIndex:1]; |
- [session_controller_ setPendingEntryIndex:0]; |
- ASSERT_EQ(0, [session_controller_ pendingEntryIndex]); |
+ [session_controller_ goToItemAtIndex:1]; |
+ [session_controller_ setPendingItemIndex:0]; |
+ ASSERT_EQ(0, [session_controller_ pendingItemIndex]); |
base::scoped_nsobject<CRWSessionEntry> pendingEntry( |
[[session_controller_ pendingEntry] retain]); |
ASSERT_TRUE(pendingEntry); |
ASSERT_EQ(1, [session_controller_ currentNavigationIndex]); |
EXPECT_EQ(2, [session_controller_ previousNavigationIndex]); |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ commitPendingItem]; |
// Verify that pending entry has been committed and current and previous entry |
// indices updated. |
EXPECT_EQ(pendingEntry, [session_controller_ lastCommittedEntry]); |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
EXPECT_FALSE([session_controller_ pendingEntry]); |
EXPECT_EQ(0, [session_controller_ currentNavigationIndex]); |
EXPECT_EQ(1, [session_controller_ previousNavigationIndex]); |
@@ -417,7 +404,7 @@ void SetUp() override { |
TEST_F(CRWSessionControllerTest, |
DiscardPendingEntryWithoutPendingOrCommittedEntry) { |
- [session_controller_ discardNonCommittedEntries]; |
+ [session_controller_ discardNonCommittedItems]; |
EXPECT_EQ(0U, [[session_controller_ entries] count]); |
EXPECT_EQ(nil, [session_controller_ currentEntry]); |
@@ -426,15 +413,14 @@ void SetUp() override { |
TEST_F(CRWSessionControllerTest, |
DiscardPendingEntryWithoutPendingEntryWithCommittedEntry) { |
// Setup committed entry |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
// Discard noncommitted entries when there is no such one |
- [session_controller_ discardNonCommittedEntries]; |
+ [session_controller_ discardNonCommittedItems]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -442,23 +428,20 @@ void SetUp() override { |
[session_controller_ currentEntry]); |
} |
-TEST_F(CRWSessionControllerTest, UpdatePendingEntryWithoutPendingEntry) { |
- [session_controller_ |
- updatePendingEntry:GURL("http://www.another.url.com")]; |
- [session_controller_ commitPendingEntry]; |
+TEST_F(CRWSessionControllerTest, updatePendingItemWithoutPendingEntry) { |
+ [session_controller_ updatePendingItem:GURL("http://www.another.url.com")]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(0U, [[session_controller_ entries] count]); |
EXPECT_EQ(nil, [session_controller_ currentEntry]); |
} |
-TEST_F(CRWSessionControllerTest, UpdatePendingEntryWithPendingEntry) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ |
- updatePendingEntry:GURL("http://www.another.url.com")]; |
+TEST_F(CRWSessionControllerTest, updatePendingItemWithPendingEntry) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ updatePendingItem:GURL("http://www.another.url.com")]; |
EXPECT_EQ( |
GURL("http://www.another.url.com/"), |
@@ -466,16 +449,14 @@ void SetUp() override { |
} |
TEST_F(CRWSessionControllerTest, |
- UpdatePendingEntryWithPendingEntryAlreadyCommited) { |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ |
- updatePendingEntry:GURL("http://www.another.url.com")]; |
- [session_controller_ commitPendingEntry]; |
+ updatePendingItemWithPendingEntryAlreadyCommited) { |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ updatePendingItem:GURL("http://www.another.url.com")]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(1U, [[session_controller_ entries] count]); |
EXPECT_EQ( |
@@ -489,15 +470,15 @@ void SetUp() override { |
// Tests inserting session controller state. |
TEST_F(CRWSessionControllerTest, InsertState) { |
// Add 1 committed and 1 pending entry to target controller. |
- [session_controller_ addPendingEntry:GURL("http://www.url.com/2") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.url.com/3") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com/2") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com/3") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
// Create source session controller with 1 committed entry. |
base::scoped_nsobject<CRWSessionController> other_session_controller( |
@@ -507,15 +488,15 @@ void SetUp() override { |
openerNavigationIndex:0 |
browserState:&browser_state_]); |
[other_session_controller setWindowName:@"test-window"]; |
- [other_session_controller addPendingEntry:GURL("http://www.url.com/0") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [other_session_controller commitPendingEntry]; |
- [other_session_controller addPendingEntry:GURL("http://www.url.com/1") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+ [other_session_controller addPendingItem:GURL("http://www.url.com/0") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [other_session_controller commitPendingItem]; |
+ [other_session_controller addPendingItem:GURL("http://www.url.com/1") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
// Insert and verify the state of target session controller. |
[session_controller_ |
@@ -525,7 +506,7 @@ void SetUp() override { |
EXPECT_EQ(2U, [[session_controller_ entries] count]); |
EXPECT_EQ(1, [session_controller_ currentNavigationIndex]); |
EXPECT_EQ(-1, [session_controller_ previousNavigationIndex]); |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
EXPECT_EQ(GURL("http://www.url.com/0"), |
[session_controller_ URLForSessionAtIndex:0]); |
@@ -538,16 +519,16 @@ void SetUp() override { |
// Tests inserting session controller state from empty session controller. |
TEST_F(CRWSessionControllerTest, InsertStateFromEmptySessionController) { |
// Add 2 committed entries to target controller. |
- [session_controller_ addPendingEntry:GURL("http://www.url.com/0") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.url.com/1") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com/0") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com/1") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
// Create empty source session controller. |
base::scoped_nsobject<CRWSessionController> other_session_controller( |
@@ -566,7 +547,7 @@ void SetUp() override { |
EXPECT_EQ(2U, [[session_controller_ entries] count]); |
EXPECT_EQ(1, [session_controller_ currentNavigationIndex]); |
EXPECT_EQ(0, [session_controller_ previousNavigationIndex]); |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
EXPECT_FALSE([session_controller_ pendingEntry]); |
EXPECT_EQ(GURL("http://www.url.com/0"), |
[session_controller_ URLForSessionAtIndex:0]); |
@@ -585,20 +566,20 @@ void SetUp() override { |
openerNavigationIndex:0 |
browserState:&browser_state_]); |
[other_session_controller setWindowName:@"test-window"]; |
- [other_session_controller addPendingEntry:GURL("http://www.url.com/0") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [other_session_controller commitPendingEntry]; |
- [other_session_controller addPendingEntry:GURL("http://www.url.com/1") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [other_session_controller commitPendingEntry]; |
- [other_session_controller addPendingEntry:GURL("http://www.url.com/2") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
+ [other_session_controller addPendingItem:GURL("http://www.url.com/0") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [other_session_controller commitPendingItem]; |
+ [other_session_controller addPendingItem:GURL("http://www.url.com/1") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [other_session_controller commitPendingItem]; |
+ [other_session_controller addPendingItem:GURL("http://www.url.com/2") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
// Insert and verify the state of target session controller. |
[session_controller_ |
@@ -608,7 +589,7 @@ void SetUp() override { |
EXPECT_EQ(2U, [[session_controller_ entries] count]); |
EXPECT_EQ(1, [session_controller_ currentNavigationIndex]); |
EXPECT_EQ(-1, [session_controller_ previousNavigationIndex]); |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
EXPECT_FALSE([session_controller_ pendingEntry]); |
EXPECT_EQ(GURL("http://www.url.com/0"), |
[session_controller_ URLForSessionAtIndex:0]); |
@@ -621,17 +602,17 @@ void SetUp() override { |
TEST_F(CRWSessionControllerTest, |
InsertStateWithPendingEntryIndexInTargetController) { |
// Add 2 committed entries and make the first entry pending. |
- [session_controller_ addPendingEntry:GURL("http://www.url.com/2") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.url.com/3") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ setPendingEntryIndex:0]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com/2") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com/3") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ setPendingItemIndex:0]; |
// Create source session controller with 1 committed entry. |
base::scoped_nsobject<CRWSessionController> other_session_controller( |
@@ -641,11 +622,11 @@ void SetUp() override { |
openerNavigationIndex:0 |
browserState:&browser_state_]); |
[other_session_controller setWindowName:@"test-window"]; |
- [other_session_controller addPendingEntry:GURL("http://www.url.com/0") |
- referrer:web::Referrer() |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [other_session_controller commitPendingEntry]; |
+ [other_session_controller addPendingItem:GURL("http://www.url.com/0") |
+ referrer:web::Referrer() |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [other_session_controller commitPendingItem]; |
// Insert and verify the state of target session controller. |
[session_controller_ |
@@ -655,7 +636,7 @@ void SetUp() override { |
EXPECT_EQ(3U, [[session_controller_ entries] count]); |
EXPECT_EQ(2, [session_controller_ currentNavigationIndex]); |
EXPECT_EQ(-1, [session_controller_ previousNavigationIndex]); |
- EXPECT_EQ(1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(1, [session_controller_ pendingItemIndex]); |
EXPECT_EQ(GURL("http://www.url.com/0"), |
[session_controller_ URLForSessionAtIndex:0]); |
EXPECT_EQ(GURL("http://www.url.com/2"), |
@@ -671,7 +652,7 @@ void SetUp() override { |
EXPECT_EQ(-1, [session_controller_ previousNavigationIndex]); |
EXPECT_FALSE([session_controller_ currentEntry]); |
EXPECT_FALSE([session_controller_ pendingEntry]); |
- EXPECT_EQ(-1, [session_controller_ pendingEntryIndex]); |
+ EXPECT_EQ(-1, [session_controller_ pendingItemIndex]); |
} |
// Helper to create a NavigationItem. |
@@ -730,39 +711,36 @@ void SetUp() override { |
// Tests index of previous navigation entry. |
TEST_F(CRWSessionControllerTest, PreviousNavigationEntry) { |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, -1); |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.url.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, -1); |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url1.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.url1.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, 0); |
- [session_controller_ |
- addPendingEntry:GURL("http://www.url2.com") |
- referrer:MakeReferrer("http://www.referer.com") |
- transition:ui::PAGE_TRANSITION_TYPED |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.url2.com") |
+ referrer:MakeReferrer("http://www.referer.com") |
+ transition:ui::PAGE_TRANSITION_TYPED |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, 1); |
- [session_controller_ goToEntryAtIndex:1]; |
+ [session_controller_ goToItemAtIndex:1]; |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, 2); |
- [session_controller_ goToEntryAtIndex:0]; |
+ [session_controller_ goToItemAtIndex:0]; |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, 1); |
- [session_controller_ goToEntryAtIndex:1]; |
+ [session_controller_ goToItemAtIndex:1]; |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, 0); |
- [session_controller_ goToEntryAtIndex:2]; |
+ [session_controller_ goToItemAtIndex:2]; |
EXPECT_EQ(session_controller_.get().previousNavigationIndex, 1); |
} |
@@ -781,9 +759,9 @@ void SetUp() override { |
GURL pushPageGurl1("http://www.firstpage.com/#push1"); |
NSString* stateObject1 = @"{'foo': 1}"; |
- [controller pushNewEntryWithURL:pushPageGurl1 |
- stateObject:stateObject1 |
- transition:ui::PAGE_TRANSITION_LINK]; |
+ [controller pushNewItemWithURL:pushPageGurl1 |
+ stateObject:stateObject1 |
+ transition:ui::PAGE_TRANSITION_LINK]; |
CRWSessionEntry* pushedEntry = [controller currentEntry]; |
web::NavigationItemImpl* pushedItem = pushedEntry.navigationItemImpl; |
NSUInteger expectedCount = 2; |
@@ -796,9 +774,9 @@ void SetUp() override { |
// Add another new entry and check size and fields again. |
GURL pushPageGurl2("http://www.firstpage.com/push2"); |
- [controller pushNewEntryWithURL:pushPageGurl2 |
- stateObject:nil |
- transition:ui::PAGE_TRANSITION_LINK]; |
+ [controller pushNewItemWithURL:pushPageGurl2 |
+ stateObject:nil |
+ transition:ui::PAGE_TRANSITION_LINK]; |
pushedEntry = [controller currentEntry]; |
pushedItem = pushedEntry.navigationItemImpl; |
expectedCount = 3; |
@@ -830,30 +808,30 @@ void SetUp() override { |
[[CRWSessionController alloc] initWithNavigationItems:std::move(items) |
currentIndex:0 |
browserState:&browser_state_]); |
- CRWSessionEntry* entry0 = [controller.get().entries objectAtIndex:0]; |
- CRWSessionEntry* entry1 = [controller.get().entries objectAtIndex:1]; |
- CRWSessionEntry* entry2 = [controller.get().entries objectAtIndex:2]; |
- CRWSessionEntry* entry3 = [controller.get().entries objectAtIndex:3]; |
- CRWSessionEntry* entry4 = [controller.get().entries objectAtIndex:4]; |
- CRWSessionEntry* entry5 = [controller.get().entries objectAtIndex:5]; |
- entry1.navigationItemImpl->SetIsCreatedFromPushState(true); |
- entry4.navigationItemImpl->SetIsCreatedFromHashChange(true); |
- entry5.navigationItemImpl->SetIsCreatedFromPushState(true); |
+ web::NavigationItemImpl* item0 = [controller items][0].get(); |
+ web::NavigationItemImpl* item1 = [controller items][1].get(); |
+ web::NavigationItemImpl* item2 = [controller items][2].get(); |
+ web::NavigationItemImpl* item3 = [controller items][3].get(); |
+ web::NavigationItemImpl* item4 = [controller items][4].get(); |
+ web::NavigationItemImpl* item5 = [controller items][5].get(); |
+ item1->SetIsCreatedFromPushState(true); |
+ item4->SetIsCreatedFromHashChange(true); |
+ item5->SetIsCreatedFromPushState(true); |
EXPECT_FALSE( |
- [controller isSameDocumentNavigationBetweenEntry:entry0 andEntry:entry0]); |
+ [controller isSameDocumentNavigationBetweenItem:item0 andItem:item0]); |
EXPECT_TRUE( |
- [controller isSameDocumentNavigationBetweenEntry:entry0 andEntry:entry1]); |
+ [controller isSameDocumentNavigationBetweenItem:item0 andItem:item1]); |
EXPECT_TRUE( |
- [controller isSameDocumentNavigationBetweenEntry:entry5 andEntry:entry3]); |
+ [controller isSameDocumentNavigationBetweenItem:item5 andItem:item3]); |
EXPECT_TRUE( |
- [controller isSameDocumentNavigationBetweenEntry:entry4 andEntry:entry3]); |
+ [controller isSameDocumentNavigationBetweenItem:item4 andItem:item3]); |
EXPECT_FALSE( |
- [controller isSameDocumentNavigationBetweenEntry:entry1 andEntry:entry2]); |
+ [controller isSameDocumentNavigationBetweenItem:item1 andItem:item2]); |
EXPECT_FALSE( |
- [controller isSameDocumentNavigationBetweenEntry:entry0 andEntry:entry5]); |
+ [controller isSameDocumentNavigationBetweenItem:item0 andItem:item5]); |
EXPECT_FALSE( |
- [controller isSameDocumentNavigationBetweenEntry:entry2 andEntry:entry4]); |
+ [controller isSameDocumentNavigationBetweenItem:item2 andItem:item4]); |
} |
TEST_F(CRWSessionControllerTest, UpdateCurrentEntry) { |
@@ -874,8 +852,8 @@ void SetUp() override { |
// Replace current entry and check the size of history and fields of the |
// modified entry. |
- [controller updateCurrentEntryWithURL:replacePageGurl1 |
- stateObject:stateObject1]; |
+ [controller updateCurrentItemWithURL:replacePageGurl1 |
+ stateObject:stateObject1]; |
CRWSessionEntry* replacedEntry = [controller currentEntry]; |
web::NavigationItemImpl* replacedItem = replacedEntry.navigationItemImpl; |
NSUInteger expectedCount = 3; |
@@ -888,7 +866,7 @@ void SetUp() override { |
// Replace current entry and check size and fields again. |
GURL replacePageGurl2("http://www.firstpage.com/#replace2"); |
- [controller.get() updateCurrentEntryWithURL:replacePageGurl2 stateObject:nil]; |
+ [controller.get() updateCurrentItemWithURL:replacePageGurl2 stateObject:nil]; |
replacedEntry = [controller currentEntry]; |
replacedItem = replacedEntry.navigationItemImpl; |
EXPECT_EQ(expectedCount, controller.get().entries.count); |
@@ -900,26 +878,26 @@ void SetUp() override { |
} |
TEST_F(CRWSessionControllerTest, TestBackwardForwardEntries) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
referrer:MakeReferrer("http://www.example.com/a") |
transition:ui::PAGE_TRANSITION_LINK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/1") |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/1") |
referrer:MakeReferrer("http://www.example.com/b") |
transition:ui::PAGE_TRANSITION_LINK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/redirect") |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/redirect") |
referrer:MakeReferrer("http://www.example.com/r") |
transition:ui::PAGE_TRANSITION_IS_REDIRECT_MASK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/2") |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/2") |
referrer:MakeReferrer("http://www.example.com/c") |
transition:ui::PAGE_TRANSITION_LINK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(3, session_controller_.get().currentNavigationIndex); |
NSArray* backEntries = [session_controller_ backwardEntries]; |
@@ -928,11 +906,11 @@ void SetUp() override { |
EXPECT_EQ("http://www.example.com/redirect", |
[[backEntries objectAtIndex:0] navigationItem]->GetURL().spec()); |
- [session_controller_ goToEntryAtIndex:1]; |
+ [session_controller_ goToItemAtIndex:1]; |
EXPECT_EQ(1U, [[session_controller_ backwardEntries] count]); |
EXPECT_EQ(1U, [[session_controller_ forwardEntries] count]); |
- [session_controller_ goToEntryAtIndex:0]; |
+ [session_controller_ goToItemAtIndex:0]; |
NSArray* forwardEntries = [session_controller_ forwardEntries]; |
EXPECT_EQ(0U, [[session_controller_ backwardEntries] count]); |
EXPECT_EQ(2U, [forwardEntries count]); |
@@ -942,61 +920,61 @@ void SetUp() override { |
// Tests going to entries with existing and non-existing indices. |
TEST_F(CRWSessionControllerTest, GoToEntryAtIndex) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
referrer:MakeReferrer("http://www.example.com/a") |
transition:ui::PAGE_TRANSITION_LINK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/1") |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/1") |
referrer:MakeReferrer("http://www.example.com/b") |
transition:ui::PAGE_TRANSITION_LINK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/redirect") |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/redirect") |
referrer:MakeReferrer("http://www.example.com/r") |
transition:ui::PAGE_TRANSITION_IS_REDIRECT_MASK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/2") |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/2") |
referrer:MakeReferrer("http://www.example.com/c") |
transition:ui::PAGE_TRANSITION_LINK |
rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/3") |
- referrer:MakeReferrer("http://www.example.com/d") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:NO]; |
- [session_controller_ addTransientEntryWithURL:GURL("http://www.example.com")]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/3") |
+ referrer:MakeReferrer("http://www.example.com/d") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:NO]; |
+ [session_controller_ addTransientItemWithURL:GURL("http://www.example.com")]; |
EXPECT_EQ(3, session_controller_.get().currentNavigationIndex); |
EXPECT_EQ(2, session_controller_.get().previousNavigationIndex); |
EXPECT_TRUE(session_controller_.get().pendingEntry); |
EXPECT_TRUE(session_controller_.get().transientEntry); |
// Going back should discard transient and pending entries. |
- [session_controller_ goToEntryAtIndex:1]; |
+ [session_controller_ goToItemAtIndex:1]; |
EXPECT_EQ(1, session_controller_.get().currentNavigationIndex); |
EXPECT_EQ(3, session_controller_.get().previousNavigationIndex); |
EXPECT_FALSE(session_controller_.get().pendingEntry); |
EXPECT_FALSE(session_controller_.get().transientEntry); |
// Going forward should discard transient entry. |
- [session_controller_ addTransientEntryWithURL:GURL("http://www.example.com")]; |
+ [session_controller_ addTransientItemWithURL:GURL("http://www.example.com")]; |
EXPECT_TRUE(session_controller_.get().transientEntry); |
- [session_controller_ goToEntryAtIndex:2]; |
+ [session_controller_ goToItemAtIndex:2]; |
EXPECT_EQ(2, session_controller_.get().currentNavigationIndex); |
EXPECT_EQ(1, session_controller_.get().previousNavigationIndex); |
EXPECT_FALSE(session_controller_.get().transientEntry); |
// Out of bounds navigations should be no-op. |
- [session_controller_ goToEntryAtIndex:-1]; |
+ [session_controller_ goToItemAtIndex:-1]; |
EXPECT_EQ(2, session_controller_.get().currentNavigationIndex); |
EXPECT_EQ(1, session_controller_.get().previousNavigationIndex); |
- [session_controller_ goToEntryAtIndex:NSIntegerMax]; |
+ [session_controller_ goToItemAtIndex:NSIntegerMax]; |
EXPECT_EQ(2, session_controller_.get().currentNavigationIndex); |
EXPECT_EQ(1, session_controller_.get().previousNavigationIndex); |
// Going to current index should not change the previous index. |
- [session_controller_ goToEntryAtIndex:2]; |
+ [session_controller_ goToItemAtIndex:2]; |
EXPECT_EQ(2, session_controller_.get().currentNavigationIndex); |
EXPECT_EQ(1, session_controller_.get().previousNavigationIndex); |
} |
@@ -1004,7 +982,7 @@ void SetUp() override { |
// Tests that visible URL is the same as transient URL if there are no committed |
// entries. |
TEST_F(CRWSessionControllerTest, VisibleEntryWithSingleTransientEntry) { |
- [session_controller_ addTransientEntryWithURL:GURL("http://www.example.com")]; |
+ [session_controller_ addTransientItemWithURL:GURL("http://www.example.com")]; |
web::NavigationItem* visible_item = |
[[session_controller_ visibleEntry] navigationItem]; |
ASSERT_TRUE(visible_item); |
@@ -1014,12 +992,12 @@ void SetUp() override { |
// Tests that visible URL is the same as transient URL if there is a committed |
// entry. |
TEST_F(CRWSessionControllerTest, VisibleEntryWithCommittedAndTransientEntries) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addTransientEntryWithURL:GURL("http://www.example.com")]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addTransientItemWithURL:GURL("http://www.example.com")]; |
web::NavigationItem* visible_item = |
[[session_controller_ visibleEntry] navigationItem]; |
ASSERT_TRUE(visible_item); |
@@ -1029,10 +1007,10 @@ void SetUp() override { |
// Tests that visible URL is the same as pending URL if it was user-initiated. |
TEST_F(CRWSessionControllerTest, |
VisibleEntryWithSingleUserInitiatedPendingEntry) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:NO]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:NO]; |
web::NavigationItem* visible_item = |
[[session_controller_ visibleEntry] navigationItem]; |
ASSERT_TRUE(visible_item); |
@@ -1043,15 +1021,15 @@ void SetUp() override { |
// and there is a committed entry. |
TEST_F(CRWSessionControllerTest, |
VisibleEntryWithCommittedAndUserInitiatedPendingEntry) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/b") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:NO]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/b") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:NO]; |
web::NavigationItem* visible_item = |
[[session_controller_ visibleEntry] navigationItem]; |
ASSERT_TRUE(visible_item); |
@@ -1062,10 +1040,10 @@ void SetUp() override { |
// renderer-initiated. |
TEST_F(CRWSessionControllerTest, |
VisibleEntryWithSingleRendererInitiatedPendingEntry) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:YES]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:YES]; |
web::NavigationItem* visible_item = |
[[session_controller_ visibleEntry] navigationItem]; |
ASSERT_FALSE(visible_item); |
@@ -1075,15 +1053,15 @@ void SetUp() override { |
// renderer-initiated and there is a committed entry. |
TEST_F(CRWSessionControllerTest, |
VisibleEntryWithCommittedAndRendererInitiatedPendingEntry) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:YES]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/b") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:YES]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:YES]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/b") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:YES]; |
web::NavigationItem* visible_item = |
[[session_controller_ visibleEntry] navigationItem]; |
ASSERT_TRUE(visible_item); |
@@ -1093,18 +1071,18 @@ void SetUp() override { |
// Tests that visible URL is not the same as pending URL created via pending |
// navigation index. |
TEST_F(CRWSessionControllerTest, VisibleEntryWithPendingNavigationIndex) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/b") |
- transition:ui::PAGE_TRANSITION_LINK |
- rendererInitiated:NO]; |
- [session_controller_ commitPendingEntry]; |
- |
- [session_controller_ setPendingEntryIndex:0]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/b") |
+ transition:ui::PAGE_TRANSITION_LINK |
+ rendererInitiated:NO]; |
+ [session_controller_ commitPendingItem]; |
+ |
+ [session_controller_ setPendingItemIndex:0]; |
web::NavigationItem* visible_item = |
[[session_controller_ visibleEntry] navigationItem]; |
@@ -1115,16 +1093,16 @@ void SetUp() override { |
// Tests that |-backwardEntries| is empty if all preceding entries are |
// redirects. |
TEST_F(CRWSessionControllerTest, BackwardEntriesForAllRedirects) { |
- [session_controller_ addPendingEntry:GURL("http://www.example.com") |
- referrer:MakeReferrer("http://www.example.com/a") |
- transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT |
- rendererInitiated:YES]; |
- [session_controller_ commitPendingEntry]; |
- [session_controller_ addPendingEntry:GURL("http://www.example.com/0") |
- referrer:MakeReferrer("http://www.example.com/b") |
- transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT |
- rendererInitiated:YES]; |
- [session_controller_ commitPendingEntry]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com") |
+ referrer:MakeReferrer("http://www.example.com/a") |
+ transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT |
+ rendererInitiated:YES]; |
+ [session_controller_ commitPendingItem]; |
+ [session_controller_ addPendingItem:GURL("http://www.example.com/0") |
+ referrer:MakeReferrer("http://www.example.com/b") |
+ transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT |
+ rendererInitiated:YES]; |
+ [session_controller_ commitPendingItem]; |
EXPECT_EQ(0U, [session_controller_ backwardEntries].count); |
} |