ios/web/interstitials/web_interstitial_impl.mm - Issue 2672723003: Converted CRWSessionController to use NavigationItems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/interstitials/web_interstitial_impl.mm

Issue 2672723003: Converted CRWSessionController to use NavigationItems. (Closed)

Patch Set: test fixes, self review Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/interstitials/web_interstitial_impl.mm

diff --git a/ios/web/interstitials/web_interstitial_impl.mm b/ios/web/interstitials/web_interstitial_impl.mm

index fc1bd1db2b43469e216566602133d222c9780dd5..2e83b766c7ce18ac0eeec6e92a8d1c80b244ef39 100644

--- a/ios/web/interstitials/web_interstitial_impl.mm

+++ b/ios/web/interstitials/web_interstitial_impl.mm

@@ -64,7 +64,7 @@

// SessionController usage here.

CRWSessionController* sessionController =

navigation_manager_->GetSessionController();

- [sessionController addTransientEntryWithURL:url_];

+ [sessionController addTransientItemWithURL:url_];

// Give delegates a chance to set some states on the navigation item.

GetDelegate()->OverrideItem(navigation_manager_->GetTransientItem());

« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/navigation/crw_session_controller.h » ('j') | no next file with comments »