Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2672243002: Convert ContentAutofillDriverFactory to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, jam, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ContentAutofillDriverFactory to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2672243002 Cr-Commit-Position: refs/heads/master@{#448347} Committed: https://chromium.googlesource.com/chromium/src/+/61faa5671499375ac6aad46c219dec5cfdb86ef3

Patch Set 1 #

Patch Set 2 : fix unittests #

Total comments: 2

Patch Set 3 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M components/autofill/content/browser/content_autofill_driver.h View 2 chunks +2 lines, -4 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver_factory.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver_unittest.cc View 1 2 4 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
jam
3 years, 10 months ago (2017-02-06 15:44:33 UTC) #11
Evan Stade
https://codereview.chromium.org/2672243002/diff/20001/components/autofill/content/browser/content_autofill_driver_unittest.cc File components/autofill/content/browser/content_autofill_driver_unittest.cc (left): https://codereview.chromium.org/2672243002/diff/20001/components/autofill/content/browser/content_autofill_driver_unittest.cc#oldcode314 components/autofill/content/browser/content_autofill_driver_unittest.cc:314: EXPECT_CALL(*driver_->mock_autofill_manager(), Reset()).Times(0); did you mean to delete this expectation?
3 years, 10 months ago (2017-02-06 16:09:23 UTC) #12
jam
https://codereview.chromium.org/2672243002/diff/20001/components/autofill/content/browser/content_autofill_driver_unittest.cc File components/autofill/content/browser/content_autofill_driver_unittest.cc (left): https://codereview.chromium.org/2672243002/diff/20001/components/autofill/content/browser/content_autofill_driver_unittest.cc#oldcode314 components/autofill/content/browser/content_autofill_driver_unittest.cc:314: EXPECT_CALL(*driver_->mock_autofill_manager(), Reset()).Times(0); On 2017/02/06 16:09:23, Evan Stade wrote: > ...
3 years, 10 months ago (2017-02-06 16:58:07 UTC) #15
Evan Stade
lgtm
3 years, 10 months ago (2017-02-06 18:33:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672243002/40001
3 years, 10 months ago (2017-02-06 19:04:27 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:25:15 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/61faa5671499375ac6aad46c219d...

Powered by Google App Engine
This is Rietveld 408576698