components/autofill/content/browser/content_autofill_driver_factory.h - Issue 2672243002: Convert ContentAutofillDriverFactory to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/content_autofill_driver_factory.h

Issue 2672243002: Convert ContentAutofillDriverFactory to use the new navigation callbacks. (Closed)

Patch Set: review comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/content_autofill_driver.cc ('k') | components/autofill/content/browser/content_autofill_driver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/content_autofill_driver_factory.h

diff --git a/components/autofill/content/browser/content_autofill_driver_factory.h b/components/autofill/content/browser/content_autofill_driver_factory.h

index 2781ee4c1cfc7b838282c344ee98511bd89d98a6..63e168f60278cadd1c30b97a1158a7ada6fb5847 100644

--- a/components/autofill/content/browser/content_autofill_driver_factory.h

+++ b/components/autofill/content/browser/content_autofill_driver_factory.h

@@ -47,10 +47,6 @@ class ContentAutofillDriverFactory : public content::WebContentsObserver,

// content::WebContentsObserver:

void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;

void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;

- void DidNavigateAnyFrame(

- content::RenderFrameHost* render_frame_host,

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) override;

void DidFinishNavigation(

content::NavigationHandle* navigation_handle) override;

void WasHidden() override;