Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: components/autofill/content/browser/content_autofill_driver_factory.cc

Issue 2672243002: Convert ContentAutofillDriverFactory to use the new navigation callbacks. (Closed)
Patch Set: review comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/content_autofill_driver_factory.cc
diff --git a/components/autofill/content/browser/content_autofill_driver_factory.cc b/components/autofill/content/browser/content_autofill_driver_factory.cc
index 32465df8fa498a67799d01335e68350f1d6cad54..8dc6d34e18b610192a5f94bfd655a6d8e93991b9 100644
--- a/components/autofill/content/browser/content_autofill_driver_factory.cc
+++ b/components/autofill/content/browser/content_autofill_driver_factory.cc
@@ -110,17 +110,14 @@ void ContentAutofillDriverFactory::RenderFrameDeleted(
frame_driver_map_.erase(render_frame_host);
}
-void ContentAutofillDriverFactory::DidNavigateAnyFrame(
- content::RenderFrameHost* render_frame_host,
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) {
- frame_driver_map_[render_frame_host]->DidNavigateFrame(details, params);
-}
-
void ContentAutofillDriverFactory::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
- if (navigation_handle->HasCommitted())
- client_->HideAutofillPopup();
+ if (!navigation_handle->HasCommitted())
+ return;
+
+ client_->HideAutofillPopup();
+ frame_driver_map_[navigation_handle->GetRenderFrameHost()]->
+ DidNavigateFrame(navigation_handle);
}
void ContentAutofillDriverFactory::WasHidden() {

Powered by Google App Engine
This is Rietveld 408576698