[ic] Fix StoreIC_SlowSloppy/Strict builtins.

[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode is that the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind. Same applies to
the other stubs which are neither IC dispatchers nor handlers.

BUG=v8:5917
Review-Url: https://codereview.chromium.org/2677603004
Cr-Commit-Position: refs/heads/master@{#42958}
Committed: https://chromium.googlesource.com/v8/v8/+/8f2245bf9995d00ea74f9083dca40b08e2e49943

[Igor Sheludko, 2017-02-03 17:32:47]

Description was changed from

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode was the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

BUG=v8:5917
==========

to

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode was the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

BUG=v8:5917
==========

[Igor Sheludko, 2017-02-03 17:37:17]

Description was changed from

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode was the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

BUG=v8:5917
==========

to

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode was the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind.

BUG=v8:5917
==========

[Igor Sheludko, 2017-02-03 17:42:28]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2017-02-03 17:42:36]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-02-03 17:43:37]

Description was changed from

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode was the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind.

BUG=v8:5917
==========

to

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode was the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind. Same applies to
the other stubs which are neither IC dispatchers nor handlers.

BUG=v8:5917
==========

[Igor Sheludko, 2017-02-03 17:43:42]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 17:43:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-02-03 17:43:59]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2017-02-03 17:44:00]

PTAL

[commit-bot: I haz the power, 2017-02-03 18:15:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:15:39]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2017-02-03 20:05:01]

lgtm

[Igor Sheludko, 2017-02-03 20:17:15]

Description was changed from

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode was the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind. Same applies to
the other stubs which are neither IC dispatchers nor handlers.

BUG=v8:5917
==========

to

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode is that the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind. Same applies to
the other stubs which are neither IC dispatchers nor handlers.

BUG=v8:5917
==========

[Igor Sheludko, 2017-02-06 09:30:28]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 09:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 09:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 09:32:21]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[Igor Sheludko, 2017-02-06 10:09:57]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-02-06 10:10:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 10:41:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486375797294470,
"parent_rev": "01c2b45560cb8fa342f57520d0e19ec0ef9709da", "commit_rev":
"8f2245bf9995d00ea74f9083dca40b08e2e49943"}

[commit-bot: I haz the power, 2017-02-06 10:41:16]

Description was changed from

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode is that the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind. Same applies to
the other stubs which are neither IC dispatchers nor handlers.

BUG=v8:5917
==========

to

==========
[ic] Fix StoreIC_SlowSloppy/Strict builtins.

... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
language mode is that the stub can be re-used through megamorphic stub cache for
an IC with incompatible language mode. KeyedStoreIC_Slow already does the
right thing - it decodes the language mode from the IC slot kind.

This CL also fixes the code kinds of the slow IC handlers. The code kind of
IC handlers is used only for checking that the handler was added to the right
megamorphic stub cache, which expect the handlers' code kinds to be either
Code::LOAD_IC or Code::STORE_IC.

And the megamorphic builtins are just helper code stubs that are called from
IC dispatchers, therefore they should have BUILTIN code kind. Same applies to
the other stubs which are neither IC dispatchers nor handlers.

BUG=v8:5917

Review-Url: https://codereview.chromium.org/2677603004
Cr-Commit-Position: refs/heads/master@{#42958}
Committed:
https://chromium.googlesource.com/v8/v8/+/8f2245bf9995d00ea74f9083dca40b08e2e...
==========

[commit-bot: I haz the power, 2017-02-06 10:41:17]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/8f2245bf9995d00ea74f9083dca40b08e2e...