Removes unnecessary mock methods in fake identity service

Removes unnecessary mock methods in fake identity service.

Fake identity service is not a mock, and it shouldn't use mocks when possible.
Those mocked methods were never overriden anyway. 

BUG=None

Review-Url: https://codereview.chromium.org/2670843003
Cr-Commit-Position: refs/heads/master@{#448012}
Committed: https://chromium.googlesource.com/chromium/src/+/4cb58b4a871a66255e0cc5412ce250db54c74e07

[stkhapugin, 2017-02-02 15:15:57]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 15:16:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 15:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 15:37:46]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-02-02 16:39:44]

stkhapugin@chromium.org changed reviewers:
+ msarda@chromium.org, sdefresne@chromium.org

[stkhapugin, 2017-02-02 16:39:44]

msarda@chromium.org: Please review changes in 

sdefresne@chromium.org: Please review changes in 

PTAL

[stkhapugin, 2017-02-02 16:40:45]

Description was changed from

==========
Removes unnecessary mock methods in fake identity service

BUG=
==========

to

==========
Removes unnecessary mock methods in fake identity service.

Fake identity service is not a mock, and it shouldn't use mocks when possible.
Those mocked methods were never overriden anyway. 

BUG=None
==========

[msarda, 2017-02-02 17:15:18]

LGTM 

Thank you for the cleanup.

[sdefresne, 2017-02-03 09:17:06]

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
(right):

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:45:
virtual void GetAccessToken(ChromeIdentity* identity,
This is a method overridden from ChromeIdentityService, so should be marked
override:

  void GetAccessToken(ChromeIdentity* identity,
                      const std::string& client_id,
                      const std::string& client_secret,
                      const std::set<std::string>& scoped,
                      const ios::AccessTokenCallback& callback) override;

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:51:
virtual void GetAvatarForIdentity(ChromeIdentity* identity,
ditto

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:54:
virtual UIImage* GetCachedAvatarForIdentity(ChromeIdentity* identity);
ditto

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:56:
virtual void GetHostedDomainForIdentity(ChromeIdentity* identity,
ditto

[stkhapugin, 2017-02-03 10:12:34]

thanks, ptal

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
(right):

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:45:
virtual void GetAccessToken(ChromeIdentity* identity,
On 2017/02/03 09:17:05, sdefresne wrote:
> This is a method overridden from ChromeIdentityService, so should be marked
> override:
> 
>   void GetAccessToken(ChromeIdentity* identity,
>                       const std::string& client_id,
>                       const std::string& client_secret,
>                       const std::set<std::string>& scoped,
>                       const ios::AccessTokenCallback& callback) override;

Done.

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:51:
virtual void GetAvatarForIdentity(ChromeIdentity* identity,
On 2017/02/03 09:17:05, sdefresne wrote:
> ditto

Done.

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:54:
virtual UIImage* GetCachedAvatarForIdentity(ChromeIdentity* identity);
On 2017/02/03 09:17:05, sdefresne wrote:
> ditto

Done.

https://codereview.chromium.org/2670843003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:56:
virtual void GetHostedDomainForIdentity(ChromeIdentity* identity,
On 2017/02/03 09:17:06, sdefresne wrote:
> ditto

Done.

[sdefresne, 2017-02-03 10:29:51]

lgtm

[stkhapugin, 2017-02-03 15:49:31]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-02-03 15:49:32]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2670843003/#ps20001
(title: "override")

[commit-bot: I haz the power, 2017-02-03 15:49:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 17:04:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486136971920980,
"parent_rev": "f7d20bd4cc3f16bf13dfe2cc5e11c4df2ad45937", "commit_rev":
"4cb58b4a871a66255e0cc5412ce250db54c74e07"}

[commit-bot: I haz the power, 2017-02-03 17:04:42]

Description was changed from

==========
Removes unnecessary mock methods in fake identity service.

Fake identity service is not a mock, and it shouldn't use mocks when possible.
Those mocked methods were never overriden anyway. 

BUG=None
==========

to

==========
Removes unnecessary mock methods in fake identity service.

Fake identity service is not a mock, and it shouldn't use mocks when possible.
Those mocked methods were never overriden anyway. 

BUG=None

Review-Url: https://codereview.chromium.org/2670843003
Cr-Commit-Position: refs/heads/master@{#448012}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cb58b4a871a66255e0cc5412ce2...
==========

[commit-bot: I haz the power, 2017-02-03 17:04:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cb58b4a871a66255e0cc5412ce2...