[ObjC ARC] Converts ios/chrome/browser/ui/history:eg_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/history:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2673553003
Cr-Commit-Position: refs/heads/master@{#448333}
Committed: https://chromium.googlesource.com/chromium/src/+/58fbeca88c6fe663238eacd82c8943cafb304df3

[stkhapugin, 2017-02-02 14:13:57]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 14:14:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 15:30:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 15:30:15]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-02-03 12:30:02]

stkhapugin@chromium.org changed reviewers:
+ marq@chromium.org

[stkhapugin, 2017-02-03 12:30:02]

ptal

[marq (ping after 24h), 2017-02-03 14:26:14]

https://codereview.chromium.org/2673553003/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
(right):

https://codereview.chromium.org/2673553003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:55:
virtual UIImage* GetCachedAvatarForIdentity(
Add a comment explaining why this can't be mocked like the other methods.

[stkhapugin, 2017-02-03 15:49:07]

PTAL

https://codereview.chromium.org/2673553003/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
(right):

https://codereview.chromium.org/2673553003/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h:55:
virtual UIImage* GetCachedAvatarForIdentity(
On 2017/02/03 14:26:14, marq wrote:
> Add a comment explaining why this can't be mocked like the other methods.

I actually made a separate CL where I've addressed this.

[marq (ping after 24h), 2017-02-06 12:47:06]

lgtm

[stkhapugin, 2017-02-06 17:48:27]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-02-06 17:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:06:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486403307749450,
"parent_rev": "6c18b1e861ec6a9c96d24b3bd962688e50c83597", "commit_rev":
"58fbeca88c6fe663238eacd82c8943cafb304df3"}

[commit-bot: I haz the power, 2017-02-06 19:06:59]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/history:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/history:eg_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2673553003
Cr-Commit-Position: refs/heads/master@{#448333}
Committed:
https://chromium.googlesource.com/chromium/src/+/58fbeca88c6fe663238eacd82c89...
==========

[commit-bot: I haz the power, 2017-02-06 19:07:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/58fbeca88c6fe663238eacd82c89...