Removes unnecessary mock methods in fake identity service

ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_SIGNIN_FAKE_CHROME_IDENTITY_SERVICE_H_
 #define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_SIGNIN_FAKE_CHROME_IDENTITY_SERVICE_H_
 
 #include "ios/public/provider/chrome/browser/signin/chrome_identity_service.h"
 
 #include "base/mac/scoped_nsobject.h"
@@ skipping 24 matching lines @@
 
   bool IsValidIdentity(ChromeIdentity* identity) const override;
   ChromeIdentity* GetIdentityWithGaiaID(
       const std::string& gaia_id) const override;
   bool HasIdentities() const override;
   NSArray* GetAllIdentities() const override;
   NSArray* GetAllIdentitiesSortedForDisplay() const override;
   void ForgetIdentity(ChromeIdentity* identity,
                       ForgetIdentityCallback callback) override;
 
-  MOCK_METHOD5(GetAccessToken,
-               void(ChromeIdentity* identity,
-                    const std::string& client_id,
-                    const std::string& client_secret,
-                    const std::set<std::string>& scopes,
-                    const ios::AccessTokenCallback& callback));
+  virtual void GetAccessToken(ChromeIdentity* identity,

[sdefresne, 2017/02/03 09:17:05]

This is a method overridden from ChromeIdentityService, so should be marked
override:

  void GetAccessToken(ChromeIdentity* identity,
                      const std::string& client_id,
                      const std::string& client_secret,
                      const std::set<std::string>& scoped,
                      const ios::AccessTokenCallback& callback) override;

[stkhapugin, 2017/02/03 10:12:33]

Done.

+                              const std::string& client_id,
+                              const std::string& client_secret,
+                              const std::set<std::string>& scopes,
+                              const ios::AccessTokenCallback& callback);
 
-  MOCK_METHOD2(GetAvatarForIdentity,
-               void(ChromeIdentity* identity, GetAvatarCallback callback));
+  virtual void GetAvatarForIdentity(ChromeIdentity* identity,

[sdefresne, 2017/02/03 09:17:05]

ditto

[stkhapugin, 2017/02/03 10:12:34]

Done.

+                                    GetAvatarCallback callback);
 
-  MOCK_METHOD1(GetCachedAvatarForIdentity, UIImage*(ChromeIdentity* identity));
+  virtual UIImage* GetCachedAvatarForIdentity(ChromeIdentity* identity);

[sdefresne, 2017/02/03 09:17:05]

ditto

[stkhapugin, 2017/02/03 10:12:33]

Done.

 
-  MOCK_METHOD2(GetHostedDomainForIdentity,
-               void(ChromeIdentity* identity,
-                    GetHostedDomainCallback callback));
+  virtual void GetHostedDomainForIdentity(ChromeIdentity* identity,

[sdefresne, 2017/02/03 09:17:06]

ditto

[stkhapugin, 2017/02/03 10:12:34]

Done.

+                                          GetHostedDomainCallback callback);
 
   MOCK_METHOD1(GetMDMDeviceStatus,
                ios::MDMDeviceStatus(NSDictionary* user_info));
 
   MOCK_METHOD3(HandleMDMNotification,
                bool(ChromeIdentity* identity,
                     NSDictionary* user_info,
                     ios::MDMStatusCallback callback));
 
   // Sets up the mock methods for integration tests.
   void SetUpForIntegrationTests();
 
   // Adds the identities given their name.
   void AddIdentities(NSArray* identitiesNames);
 
   // Adds |identity| to the available identities.
   void AddIdentity(ChromeIdentity* identity);
 
  private:
   base::scoped_nsobject<NSMutableArray> identities_;
 };
 
 }  // namespace ios
 
 #endif  // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_SIGNIN_FAKE_CHROME_IDENTITY_SERVICE_H_