Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2737783003: Add GTK3 and dependent instrumented libraries (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GTK3 and dependent instrumented libraries This cl adds a GTK3 instrumented library. It also adds libatspi and libatk-bridge which are GTK3 dependencies. Finally, update the nss patch so it applies to the latest version. BUG=698252 R=eugenis@chromium.org Review-Url: https://codereview.chromium.org/2737783003 Cr-Commit-Position: refs/heads/master@{#455304} Committed: https://chromium.googlesource.com/chromium/src/+/49536af54da186a89cada188acbfb577843e5d46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M third_party/instrumented_libraries/BUILD.gn View 6 chunks +29 lines, -7 lines 0 comments Download
M third_party/instrumented_libraries/patches/nss.diff View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/instrumented_libraries/scripts/pre-build/libgtk-3-0.sh View 1 chunk +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (9 generated)
Tom (Use chromium acct)
eugenis ptal
3 years, 9 months ago (2017-03-07 18:30:16 UTC) #3
Evgeniy Stepanov
lgtm
3 years, 9 months ago (2017-03-07 22:42:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737783003/20001
3 years, 9 months ago (2017-03-07 22:46:50 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-07 22:46:51 UTC) #10
eugenis
lgtm
3 years, 9 months ago (2017-03-07 22:48:14 UTC) #11
Evgeniy Stepanov
Do you need any help rebuilding the tarballs?
3 years, 9 months ago (2017-03-07 22:52:33 UTC) #12
Tom (Use chromium acct)
On 2017/03/07 22:52:33, Evgeniy Stepanov wrote: > Do you need any help rebuilding the tarballs? ...
3 years, 9 months ago (2017-03-07 22:56:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737783003/20001
3 years, 9 months ago (2017-03-07 22:57:11 UTC) #15
Evgeniy Stepanov
On 2017/03/07 22:56:18, Tom Anderson wrote: > On 2017/03/07 22:52:33, Evgeniy Stepanov wrote: > > ...
3 years, 9 months ago (2017-03-07 22:57:54 UTC) #16
Tom (Use chromium acct)
On 2017/03/07 22:57:54, Evgeniy Stepanov wrote: > On 2017/03/07 22:56:18, Tom Anderson wrote: > > ...
3 years, 9 months ago (2017-03-07 23:00:36 UTC) #17
Evgeniy Stepanov
On 2017/03/07 23:00:36, Tom Anderson wrote: > On 2017/03/07 22:57:54, Evgeniy Stepanov wrote: > > ...
3 years, 9 months ago (2017-03-07 23:02:25 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 00:12:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/49536af54da186a89cada188acbf...

Powered by Google App Engine
This is Rietveld 408576698