Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2754913002: Revert of Linux UI: Switch to the Gtk3 theme (Closed)

Created:
3 years, 9 months ago by Tom Anderson
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org, Elliot Glaysher, sky, Lei Zhang, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux UI: Switch to the Gtk3 theme (patchset #3 id:180001 of https://codereview.chromium.org/2670623002/ ) Reason for revert: Reverting to fix component builds on systems with Mir. Will reland (probably later today) once https://codereview.chromium.org/2756543002/ lands Original issue's description: > Linux UI: Switch to the Gtk3 theme > > Sets "use_gtk3 = true" by default. > > BUG=79722 > TBR=dpranke@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > > > Review-Url: https://codereview.chromium.org/2670623002 > > > Cr-Commit-Position: refs/heads/master@{#452118} > > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d681183a3d47b > > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#454491} > > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d13fde39e73283 > > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#455596} > Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844cb89f24d4590 TBR=erg@chromium.org,mmoss@chromium.org,thomasanderson@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=79722, 700120 Review-Url: https://codereview.chromium.org/2754913002 Cr-Commit-Position: refs/heads/master@{#457516} Committed: https://chromium.googlesource.com/chromium/src/+/fd5f9e0d7330c6cd8bbb2301acd77305aa63981c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M build/config/linux/gtk/gtk.gni View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_jessie View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_wheezy View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Tom Anderson
Created Revert of Linux UI: Switch to the Gtk3 theme
3 years, 9 months ago (2017-03-16 17:50:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754913002/1
3 years, 9 months ago (2017-03-16 17:51:35 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 19:24:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd5f9e0d7330c6cd8bbb2301acd7...

Powered by Google App Engine
This is Rietveld 408576698