MD Settings: Change search engine add button to a paper-button

MD Settings: Change search engine add button to a paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2669923002
Cr-Commit-Position: refs/heads/master@{#447886}
Committed: https://chromium.googlesource.com/chromium/src/+/b6b38131ef925b6fe394edbdd28f01811612ce7f

[scottchen, 2017-02-01 23:25:24]

Description was changed from

==========
MD Settings: Change search engine add button to a paper-button

BUG=684152
==========

to

==========
MD Settings: Change search engine add button to a paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-02-01 23:25:39]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:26:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottchen, 2017-02-01 23:44:04]

scottchen@chromium.org changed reviewers:
+ tommycli@chromium.org

[scottchen, 2017-02-01 23:44:05]

Before after ss: http://imgur.com/a/cERyF

[tommycli, 2017-02-02 00:12:55]

https://codereview.chromium.org/2669923002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.html
(left):

https://codereview.chromium.org/2669923002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.html:41:
$i18n{searchEnginesAddSearchEngine}
if not used, remove from grd and cc.

Also... if there are any more instances of the need to align these
paper-buttons, consider making a shared class maybe called
'header-aligned-button' or something.

[scottchen, 2017-02-02 01:40:58]

https://codereview.chromium.org/2669923002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.html
(left):

https://codereview.chromium.org/2669923002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.html:41:
$i18n{searchEnginesAddSearchEngine}
Looks like it's still used here:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search...

re: header-aligned-button, I didn't want to add it into settings_shared_css.html
for just 2 instances, since it'll be copied too many times by every
include="shared_style". But now to think of it, if we're committed to making
that copying of shared_styles go away, I guess I might as well do it the right
way now.

[tommycli, 2017-02-02 18:07:53]

lgtm

[scottchen, 2017-02-02 22:34:55]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:35:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:53:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486074895262340,
"parent_rev": "4dbcfdcb2ce26ac7f1a3effa09631053fe5a224a", "commit_rev":
"b6b38131ef925b6fe394edbdd28f01811612ce7f"}

[commit-bot: I haz the power, 2017-02-02 23:53:43]

Description was changed from

==========
MD Settings: Change search engine add button to a paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Change search engine add button to a paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2669923002
Cr-Commit-Position: refs/heads/master@{#447886}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6b38131ef925b6fe394edbdd28f...
==========

[commit-bot: I haz the power, 2017-02-02 23:53:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6b38131ef925b6fe394edbdd28f...