MD Settings: Change autofill addr/cc add buttons to paper-button

MD Settings: Change autofill addr/cc add buttons to paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2667253002
Cr-Commit-Position: refs/heads/master@{#448444}
Committed: https://chromium.googlesource.com/chromium/src/+/52a008bec9f907b1b142486d2f3feb036de02c55

[scottchen, 2017-02-01 23:41:23]

Description was changed from

==========
MD Settings: Change autofill addr/cc add buttons to paper-button

BUG=684152
==========

to

==========
MD Settings: Change autofill addr/cc add buttons to paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-02-01 23:45:57]

scottchen@chromium.org changed reviewers:
+ tommycli@chromium.org

[scottchen, 2017-02-01 23:45:57]

before after ss: http://imgur.com/a/IGfRc

[tommycli, 2017-02-02 00:11:56]

https://codereview.chromium.org/2667253002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
(left):

https://codereview.chromium.org/2667253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:87:
$i18n{addAddress}
If this string is no longer used it can be removed from the grd file and cc file
also.

https://codereview.chromium.org/2667253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:143:
$i18n{addCreditCard}
same

[scottchen, 2017-02-02 01:32:24]

https://codereview.chromium.org/2667253002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
(left):

https://codereview.chromium.org/2667253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:87:
$i18n{addAddress}
On 2017/02/02 00:11:56, tommycli wrote:
> If this string is no longer used it can be removed from the grd file and cc
file
> also.

Done.

https://codereview.chromium.org/2667253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:143:
$i18n{addCreditCard}
On 2017/02/02 00:11:56, tommycli wrote:
> same

Done.

[tommycli, 2017-02-02 18:08:34]

lgtm

[scottchen, 2017-02-03 01:32:39]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:33:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 02:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 02:18:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottchen, 2017-02-06 21:53:21]

The CQ bit was checked by scottchen@chromium.org

[scottchen, 2017-02-06 21:53:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2667253002/#ps60001
(title: "update a test that was using the wrong string")

[commit-bot: I haz the power, 2017-02-06 21:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 21:54:15]

This CL has an open dependency (Issue 2670963003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[scottchen, 2017-02-06 21:54:44]

Patchset #5 (id:80001) has been deleted

[scottchen, 2017-02-06 22:02:07]

The CQ bit was checked by scottchen@chromium.org

[scottchen, 2017-02-06 22:02:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2667253002/#ps100001
(title: "Merge branch 'master' into add-button")

[commit-bot: I haz the power, 2017-02-06 22:03:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 23:50:40]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486418527502030,
"parent_rev": "0ceeb08579867a3237898ced1bd52a5e2d2375dd", "commit_rev":
"52a008bec9f907b1b142486d2f3feb036de02c55"}

[commit-bot: I haz the power, 2017-02-06 23:52:03]

Description was changed from

==========
MD Settings: Change autofill addr/cc add buttons to paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Change autofill addr/cc add buttons to paper-button

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2667253002
Cr-Commit-Position: refs/heads/master@{#448444}
Committed:
https://chromium.googlesource.com/chromium/src/+/52a008bec9f907b1b142486d2f3f...
==========

[commit-bot: I haz the power, 2017-02-06 23:52:04]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/52a008bec9f907b1b142486d2f3f...