Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2669923002: MD Settings: Change search engine add button to a paper-button (Closed)
Patch Set: make the css selector for paper-button more precise Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/search_engines_page_test.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/html/action_link.html"> 2 <link rel="import" href="chrome://resources/html/action_link.html">
3 <link rel="import" href="chrome://resources/html/action_link_css.html"> 3 <link rel="import" href="chrome://resources/html/action_link_css.html">
4 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
5 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 5 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
6 <link rel="import" href="search_engines_browser_proxy.html"> 6 <link rel="import" href="search_engines_browser_proxy.html">
7 <link rel="import" href="search_engine_dialog.html"> 7 <link rel="import" href="search_engine_dialog.html">
8 <link rel="import" href="search_engines_list.html"> 8 <link rel="import" href="search_engines_list.html">
9 <link rel="import" href="omnibox_extension_entry.html"> 9 <link rel="import" href="omnibox_extension_entry.html">
10 <link rel="import" href="../settings_shared_css.html"> 10 <link rel="import" href="../settings_shared_css.html">
11 11
12 <dom-module id="settings-search-engines-page"> 12 <dom-module id="settings-search-engines-page">
13 <template> 13 <template>
14 <style include="settings-shared action-link"> 14 <style include="settings-shared action-link">
15 .extension-engines { 15 .extension-engines {
16 @apply(--settings-list-frame-padding); 16 @apply(--settings-list-frame-padding);
17 } 17 }
18 18
19 settings-omnibox-extension-entry { 19 settings-omnibox-extension-entry {
20 border-top: var(--settings-separator-line); 20 border-top: var(--settings-separator-line);
21 } 21 }
22 22
23 settings-omnibox-extension-entry:first-of-type { 23 settings-omnibox-extension-entry:first-of-type {
24 border-top: none; 24 border-top: none;
25 } 25 }
26
27 .settings-box > h2 + paper-button {
28 margin-top: 12px; /* Align with <h2>. */
29 }
26 </style> 30 </style>
27 <div class="settings-box first"> 31 <div class="settings-box first">
28 <h2>$i18n{searchEnginesDefault}</h2> 32 <h2>$i18n{searchEnginesDefault}</h2>
29 </div> 33 </div>
30 <settings-search-engines-list engines="[[defaultEngines]]"> 34 <settings-search-engines-list engines="[[defaultEngines]]">
31 </settings-search-engines-list> 35 </settings-search-engines-list>
32 <template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp> 36 <template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp>
33 <settings-search-engine-dialog></settings-search-engine-dialog> 37 <settings-search-engine-dialog></settings-search-engine-dialog>
34 </template> 38 </template>
39
35 <div class="settings-box first"> 40 <div class="settings-box first">
36 <h2>$i18n{searchEnginesOther}</h2> 41 <h2 class="start">$i18n{searchEnginesOther}</h2>
42 <paper-button class="secondary-button" on-tap="onAddSearchEngineTap_"
43 id="addSearchEngine">
44 $i18n{add}
45 </paper-button>
37 </div> 46 </div>
38 <settings-search-engines-list engines="[[otherEngines]]"> 47 <settings-search-engines-list engines="[[otherEngines]]">
39 <div class="list-item" id="addSearchEngine">
40 <a is="action-link" class="list-button" on-tap="onAddSearchEngineTap_">
41 $i18n{searchEnginesAddSearchEngine}
tommycli 2017/02/02 00:12:55 if not used, remove from grd and cc. Also... if t
scottchen 2017/02/02 01:40:58 Looks like it's still used here: https://cs.chromi
42 </a>
43 </div>
44 </settings-search-engines-list> 48 </settings-search-engines-list>
45
46 <template is="dom-if" if="[[showExtensionsList_]]"> 49 <template is="dom-if" if="[[showExtensionsList_]]">
47 <div class="settings-box first"> 50 <div class="settings-box first">
48 <h2>$i18n{searchEnginesExtension}</h2> 51 <h2>$i18n{searchEnginesExtension}</h2>
49 </div> 52 </div>
50 <iron-list id="extensions" class="extension-engines" selectable 53 <iron-list id="extensions" class="extension-engines" selectable
51 items="[[extensions]]"> 54 items="[[extensions]]">
52 <template> 55 <template>
53 <settings-omnibox-extension-entry engine="[[item]]" 56 <settings-omnibox-extension-entry engine="[[item]]"
54 tabindex$="[[tabIndex]]"> 57 tabindex$="[[tabIndex]]">
55 </settings-omnibox-extension-entry> 58 </settings-omnibox-extension-entry>
56 </template> 59 </template>
57 </iron-list> 60 </iron-list>
58 </template> 61 </template>
59 </template> 62 </template>
60 <script src="search_engines_page.js"></script> 63 <script src="search_engines_page.js"></script>
61 </dom-module> 64 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/search_engines_page_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698