mash: Fix MusPropertyMirrorAsh for owned properties; add test.

mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

Fallout from move to ash/public/cpp:
-Move shelf_item_types.* to ash/public/cpp
(TODO: remove stub header used for temporary forwarding)
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2669633003
Cr-Commit-Position: refs/heads/master@{#447455}
Committed: https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7d6ae4f2c9c83

[msw, 2017-01-31 22:36:14]

Hey Scott, please take a look; thanks!

[msw, 2017-01-31 22:36:17]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:36:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-01-31 22:37:37]

Description was changed from

==========
Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org
==========

to

==========
mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2017-01-31 22:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 22:43:35]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-01-31 23:25:09]

https://codereview.chromium.org/2669633003/diff/1/ash/mus/mus_property_mirror...
File ash/mus/mus_property_mirror_ash.h (right):

https://codereview.chromium.org/2669633003/diff/1/ash/mus/mus_property_mirror...
ash/mus/mus_property_mirror_ash.h:17: class ASH_EXPORT MusPropertyMirrorAsh :
public views::MusPropertyMirror {
This isn't actually used in ash, is it? Rather it's for clients, right? How
about putting it in ash/public/cpp?

[msw, 2017-02-01 01:13:59]

Patchset #3 (id:40001) has been deleted

[msw, 2017-02-01 01:21:52]

Description was changed from

==========
mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org
==========

to

==========
mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

Fallout from move to ash/public/cpp:
-Move shelf_item_types.* to ash/public/cpp
(TODO: remove stub header used for temporary forwarding)
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org
==========

[msw, 2017-02-01 01:23:56]

Patchset #3 (id:60001) has been deleted

[msw, 2017-02-01 01:25:00]

Please take another look; thanks!

https://codereview.chromium.org/2669633003/diff/1/ash/mus/mus_property_mirror...
File ash/mus/mus_property_mirror_ash.h (right):

https://codereview.chromium.org/2669633003/diff/1/ash/mus/mus_property_mirror...
ash/mus/mus_property_mirror_ash.h:17: class ASH_EXPORT MusPropertyMirrorAsh :
public views::MusPropertyMirror {
On 2017/01/31 23:25:09, sky wrote:
> This isn't actually used in ash, is it? Rather it's for clients, right? How
> about putting it in ash/public/cpp?

It took some doing, and reminded me what a mess ash is, but done.

[msw, 2017-02-01 01:25:09]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 01:25:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 02:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 02:10:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-02-01 02:20:05]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 02:20:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-02-01 03:19:41]

LGTM

[commit-bot: I haz the power, 2017-02-01 03:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 03:26:45]

Dry run: This issue passed the CQ dry run.

[msw, 2017-02-01 05:21:16]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-02-01 05:21:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 05:41:05]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485926476987200,
"parent_rev": "ab7722c427586b8b0b7e0f82e2f3e7d5d67ec46a", "commit_rev":
"612e45de4250e73fa0df767121d7d6ae4f2c9c83"}

[commit-bot: I haz the power, 2017-02-01 05:41:43]

Description was changed from

==========
mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

Fallout from move to ash/public/cpp:
-Move shelf_item_types.* to ash/public/cpp
(TODO: remove stub header used for temporary forwarding)
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org
==========

to

==========
mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

Fallout from move to ash/public/cpp:
-Move shelf_item_types.* to ash/public/cpp
(TODO: remove stub header used for temporary forwarding)
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2669633003
Cr-Commit-Position: refs/heads/master@{#447455}
Committed:
https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7...
==========

[commit-bot: I haz the power, 2017-02-01 05:41:45]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7...

[msw, 2017-02-01 08:32:26]

A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/2663383003/ by msw@chromium.org.

The reason for reverting is: Likely cause failing tests, see:
http://crbug.com/687472.

[msw, 2017-02-01 17:51:28]

Patchset #5 (id:120001) has been deleted