mash: Fix icon window property mirroring.

mash: Fix icon window property mirroring.

Supply a new ImageSkia instance [copy] as the icon property value.
('OWNED_UI_CLASS_PROPERTY_KEY' values must not be shared raw pointers)
Add a helper function like native_widget_aura.cc's SetIcon.

BUG=686936
TEST=Files app opens fine in chrome --mash
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2667743003
Cr-Commit-Position: refs/heads/master@{#447326}
Committed: https://chromium.googlesource.com/chromium/src/+/d94f1fa38da0059843cc2b9afd15f13d334b68d3

[msw, 2017-01-31 20:03:54]

Hey Scott, please take a look; thanks!

[msw, 2017-01-31 20:04:41]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 20:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-31 20:28:05]

Tricky. LGTM - it would be good to add test coverage of this.

[commit-bot: I haz the power, 2017-01-31 20:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 20:43:13]

Dry run: This issue passed the CQ dry run.

[msw, 2017-01-31 20:53:34]

I'll land this and pursue a test separately, since it'll require extra work.

[msw, 2017-01-31 20:53:38]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-01-31 20:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:00:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485896018833260, "parent_rev":
"441970c806f82e3f3705bece16f904ea42666c6a", "commit_rev":
"d94f1fa38da0059843cc2b9afd15f13d334b68d3"}

[commit-bot: I haz the power, 2017-01-31 21:01:30]

Description was changed from

==========
mash: Fix icon window property mirroring.

Supply a new ImageSkia instance [copy] as the icon property value.
('OWNED_UI_CLASS_PROPERTY_KEY' values must not be shared raw pointers)
Add a helper function like native_widget_aura.cc's SetIcon.

BUG=686936
TEST=Files app opens fine in chrome --mash
R=sky@chromium.org
==========

to

==========
mash: Fix icon window property mirroring.

Supply a new ImageSkia instance [copy] as the icon property value.
('OWNED_UI_CLASS_PROPERTY_KEY' values must not be shared raw pointers)
Add a helper function like native_widget_aura.cc's SetIcon.

BUG=686936
TEST=Files app opens fine in chrome --mash
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2667743003
Cr-Commit-Position: refs/heads/master@{#447326}
Committed:
https://chromium.googlesource.com/chromium/src/+/d94f1fa38da0059843cc2b9afd15...
==========

[commit-bot: I haz the power, 2017-01-31 21:01:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d94f1fa38da0059843cc2b9afd15...