Seems incorrect to se device_scale_factor in SetLocalSurfaceId.
Added new function SetDeviceScaleFactor to set device_scale_factor.
BUG=
R=fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Description was changed from ========== Seems incorrect to se device_scale_factor in SetLocalSurfaceId. Added new function ...
3 years, 10 months ago
(2017-02-02 12:09:33 UTC)
#1
Description was changed from
==========
Seems incorrect to se device_scale_factor in SetLocalSurfaceId.
Added new function SetDeviceScaleFactor to set device_scale_factor.
BUG=
R=fsamuel@chromium.org
==========
to
==========
Seems incorrect to se device_scale_factor in SetLocalSurfaceId.
Added new function SetDeviceScaleFactor to set device_scale_factor.
BUG=
R=fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========
Fady Samuel
https://codereview.chromium.org/2669183002/diff/1/cc/surfaces/display.cc File cc/surfaces/display.cc (right): https://codereview.chromium.org/2669183002/diff/1/cc/surfaces/display.cc#newcode108 cc/surfaces/display.cc:108: if (current_surface_id_.local_surface_id() == id) { drop the braces { ...
3 years, 10 months ago
(2017-02-02 16:34:29 UTC)
#2
When we get a new device_scale_factor, do we need a new local surface ID? Changing ...
3 years, 10 months ago
(2017-02-02 18:26:16 UTC)
#3
When we get a new device_scale_factor, do we need a new local surface ID?
Changing the code this way would remove this guarantee.
Fady Samuel
That's a good point, Wei. That got me thinking: should SetLocalSurfaceId be instead SetSurfaceInfo which ...
3 years, 10 months ago
(2017-02-02 18:27:44 UTC)
#4
That's a good point, Wei. That got me thinking: should SetLocalSurfaceId be
instead SetSurfaceInfo which includes a device_scale_factor, frame_size,
and surface ID?
Fady
On Thu, Feb 2, 2017 at 10:26 AM weiliangc@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:
> When we get a new device_scale_factor, do we need a new local surface ID?
> Changing the code this way would remove this guarantee.
>
> https://codereview.chromium.org/2669183002/
>
--
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.
weiliangc
On 2017/02/02 18:27:44, Fady Samuel wrote: > That's a good point, Wei. That got me ...
3 years, 10 months ago
(2017-02-02 18:34:10 UTC)
#5
On 2017/02/02 18:27:44, Fady Samuel wrote:
> That's a good point, Wei. That got me thinking: should SetLocalSurfaceId be
> instead SetSurfaceInfo which includes a device_scale_factor, frame_size,
> and surface ID?
>
> Fady
>
> On Thu, Feb 2, 2017 at 10:26 AM mailto:weiliangc@chromium.org via
> http://codereview.chromium.org
<mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
>
> > When we get a new device_scale_factor, do we need a new local surface ID?
> > Changing the code this way would remove this guarantee.
> >
> > https://codereview.chromium.org/2669183002/
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
Yeah that sounds good.
k.devara
https://codereview.chromium.org/2669183002/diff/1/cc/surfaces/display.cc File cc/surfaces/display.cc (right): https://codereview.chromium.org/2669183002/diff/1/cc/surfaces/display.cc#newcode126 cc/surfaces/display.cc:126: device_scale_factor_ = device_scale_factor; On 2017/02/02 16:34:29, Fady Samuel wrote: ...
3 years, 10 months ago
(2017-02-03 11:35:38 UTC)
#6
On 2017/02/02 18:34:10, weiliangc wrote: > On 2017/02/02 18:27:44, Fady Samuel wrote: > > That's ...
3 years, 10 months ago
(2017-02-03 11:36:45 UTC)
#7
On 2017/02/02 18:34:10, weiliangc wrote:
> On 2017/02/02 18:27:44, Fady Samuel wrote:
> > That's a good point, Wei. That got me thinking: should SetLocalSurfaceId be
> > instead SetSurfaceInfo which includes a device_scale_factor, frame_size,
> > and surface ID?
> >
> > Fady
> >
> > On Thu, Feb 2, 2017 at 10:26 AM mailto:weiliangc@chromium.org via
> > http://codereview.chromium.org
> <mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
> >
> > > When we get a new device_scale_factor, do we need a new local surface ID?
> > > Changing the code this way would remove this guarantee.
> > >
> > > https://codereview.chromium.org/2669183002/
> > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>
> Yeah that sounds good.
Also, I was wondering if SetLocalSurfaceId may be renamed SetCurrentSurfaceId,
meaning the current_surface associated with the display.
k.devara
The CQ bit was checked by k.devara@samsung.com to run a CQ dry run
3 years, 10 months ago
(2017-02-24 12:33:44 UTC)
#8
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
3 years, 10 months ago
(2017-02-24 12:34:08 UTC)
#11
Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.
k.devara
The CQ bit was checked by k.devara@samsung.com to run a CQ dry run
3 years, 10 months ago
(2017-02-24 12:54:09 UTC)
#12
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
3 years, 10 months ago
(2017-02-24 12:54:33 UTC)
#15
Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run
3 years, 10 months ago
(2017-02-24 15:49:39 UTC)
#16
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/316163)
3 years, 10 months ago
(2017-02-24 16:12:25 UTC)
#19
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
3 years, 10 months ago
(2017-02-25 06:48:03 UTC)
#23
Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run
3 years, 10 months ago
(2017-02-25 07:42:16 UTC)
#24
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/22271)
3 years, 10 months ago
(2017-02-25 07:53:04 UTC)
#27
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
3 years, 10 months ago
(2017-02-25 08:44:43 UTC)
#31
Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.
Issue 2669183002: Seems incorrect to se device_scale_factor in SetLocalSurfaceId.
Created 3 years, 10 months ago by k.devara
Modified 3 years, 10 months ago
Reviewers: Fady Samuel
Base URL:
Comments: 3
Chromium Code Reviews
Issue
2669183002:
Seems incorrect to se device_scale_factor in SetLocalSurfaceId.
