components/display_compositor/gpu_root_compositor_frame_sink.h - Issue 2669183002: Seems incorrect to se device_scale_factor in SetLocalSurfaceId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/display_compositor/gpu_root_compositor_frame_sink.h

Issue 2669183002: Seems incorrect to se device_scale_factor in SetLocalSurfaceId.

Patch Set: Seems incorrect to set device_scale_factor in SetLocalSurfaceId. Added new function SetDeviceScaleF… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/display_compositor/gpu_root_compositor_frame_sink.h

diff --git a/components/display_compositor/gpu_root_compositor_frame_sink.h b/components/display_compositor/gpu_root_compositor_frame_sink.h

index a978eb79d659a15e8d334e02160366595212d4e2..16337b9a5634ff0d51a107c630d78c610f50926f 100644

--- a/components/display_compositor/gpu_root_compositor_frame_sink.h

+++ b/components/display_compositor/gpu_root_compositor_frame_sink.h

@@ -51,8 +51,8 @@ class DISPLAY_COMPOSITOR_EXPORT GpuRootCompositorFrameSink

void ResizeDisplay(const gfx::Size& size) override;

void SetDisplayColorSpace(const gfx::ColorSpace& color_space) override;

void SetOutputIsSecure(bool secure) override;

- void SetLocalSurfaceId(const cc::LocalSurfaceId& local_surface_id,

- float scale_factor) override;

+ void SetLocalSurfaceId(const cc::LocalSurfaceId& local_surface_id) override;

+ void SetDeviceScaleFactor(float scale_factor) override;

// cc::mojom::MojoCompositorFrameSink:

void EvictFrame() override;