Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: cc/surfaces/display.h

Issue 2669183002: Seems incorrect to se device_scale_factor in SetLocalSurfaceId.
Patch Set: Seems incorrect to set device_scale_factor in SetLocalSurfaceId. Added new function SetDeviceScaleF… Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink.cc ('k') | cc/surfaces/display.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SURFACES_DISPLAY_H_ 5 #ifndef CC_SURFACES_DISPLAY_H_
6 #define CC_SURFACES_DISPLAY_H_ 6 #define CC_SURFACES_DISPLAY_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 const FrameSinkId& frame_sink_id, 58 const FrameSinkId& frame_sink_id,
59 BeginFrameSource* begin_frame_source, 59 BeginFrameSource* begin_frame_source,
60 std::unique_ptr<OutputSurface> output_surface, 60 std::unique_ptr<OutputSurface> output_surface,
61 std::unique_ptr<DisplayScheduler> scheduler, 61 std::unique_ptr<DisplayScheduler> scheduler,
62 std::unique_ptr<TextureMailboxDeleter> texture_mailbox_deleter); 62 std::unique_ptr<TextureMailboxDeleter> texture_mailbox_deleter);
63 63
64 ~Display() override; 64 ~Display() override;
65 65
66 void Initialize(DisplayClient* client, SurfaceManager* surface_manager); 66 void Initialize(DisplayClient* client, SurfaceManager* surface_manager);
67 67
68 void SetLocalSurfaceId(const LocalSurfaceId& id);
68 // device_scale_factor is used to communicate to the external window system 69 // device_scale_factor is used to communicate to the external window system
69 // what scale this was rendered at. 70 // what scale this was rendered at.
70 void SetLocalSurfaceId(const LocalSurfaceId& id, float device_scale_factor); 71 void SetDeviceScaleFactor(float device_scale_factor);
71 void SetVisible(bool visible); 72 void SetVisible(bool visible);
72 void Resize(const gfx::Size& new_size); 73 void Resize(const gfx::Size& new_size);
73 void SetColorSpace(const gfx::ColorSpace& color_space); 74 void SetColorSpace(const gfx::ColorSpace& color_space);
74 void SetOutputIsSecure(bool secure); 75 void SetOutputIsSecure(bool secure);
75 76
76 const SurfaceId& CurrentSurfaceId(); 77 const SurfaceId& CurrentSurfaceId();
77 78
78 // DisplaySchedulerClient implementation. 79 // DisplaySchedulerClient implementation.
79 bool DrawAndSwap() override; 80 bool DrawAndSwap() override;
80 81
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 SoftwareRenderer* software_renderer_ = nullptr; 126 SoftwareRenderer* software_renderer_ = nullptr;
126 std::vector<ui::LatencyInfo> stored_latency_info_; 127 std::vector<ui::LatencyInfo> stored_latency_info_;
127 128
128 private: 129 private:
129 DISALLOW_COPY_AND_ASSIGN(Display); 130 DISALLOW_COPY_AND_ASSIGN(Display);
130 }; 131 };
131 132
132 } // namespace cc 133 } // namespace cc
133 134
134 #endif // CC_SURFACES_DISPLAY_H_ 135 #endif // CC_SURFACES_DISPLAY_H_
OLDNEW
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink.cc ('k') | cc/surfaces/display.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698