Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: cc/surfaces/display_unittest.cc

Issue 2669183002: Seems incorrect to se device_scale_factor in SetLocalSurfaceId.
Patch Set: Seems incorrect to set device_scale_factor in SetLocalSurfaceId. Added new function SetDeviceScaleF… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/display.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/display_unittest.cc
diff --git a/cc/surfaces/display_unittest.cc b/cc/surfaces/display_unittest.cc
index 159c7ab7035faef705196bc69f8c3975b97c364c..77a1b5d109b86380a7d4366b3d7ebf53cd83f00b 100644
--- a/cc/surfaces/display_unittest.cc
+++ b/cc/surfaces/display_unittest.cc
@@ -189,7 +189,8 @@ TEST_F(DisplayTest, DisplayDamaged) {
LocalSurfaceId local_surface_id(id_allocator_.GenerateId());
EXPECT_FALSE(scheduler_->damaged);
EXPECT_FALSE(scheduler_->has_new_root_surface);
- display_->SetLocalSurfaceId(local_surface_id, 1.f);
+ display_->SetLocalSurfaceId(local_surface_id);
+ display_->SetDeviceScaleFactor(1.f);
EXPECT_FALSE(scheduler_->damaged);
EXPECT_FALSE(scheduler_->display_resized_);
EXPECT_TRUE(scheduler_->has_new_root_surface);
@@ -444,7 +445,8 @@ TEST_F(DisplayTest, Finish) {
StubDisplayClient client;
display_->Initialize(&client, &manager_);
- display_->SetLocalSurfaceId(local_surface_id, 1.f);
+ display_->SetLocalSurfaceId(local_surface_id);
+ display_->SetDeviceScaleFactor(1.f);
display_->Resize(gfx::Size(100, 100));
« no previous file with comments | « cc/surfaces/display.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698