[Extensions] Remove FeatureSwitch::easy_off_store_install

[Extensions] Remove FeatureSwitch::easy_off_store_install

The "easy off-store install" switch is used to determine whether or not
chrome will automatically install an extension that isn't hosted in the
webstore if the user downloads it. However, this has been disabled on
all platforms, and has no associated commandline switch or flag, so it
is permanently disabled. The only usages are in tests.

Remove the feature switch and add a lighter-weight test function to
accommodate.

Also re-enable an effectively-disabled extension browsertest (which only
ran when the easy off-store install switch was enabled - and that was
never true).

BUG=687623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668863002
Cr-Commit-Position: refs/heads/master@{#448311}
Committed: https://chromium.googlesource.com/chromium/src/+/10f3454a3b79fc102ebb1b71e48bedf790eaccba

[Devlin, 2017-01-31 23:42:38]

Description was changed from

==========
removed

BUG=
==========

to

==========
removed

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2017-02-01 01:22:36]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 01:23:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-02-01 17:09:56]

Description was changed from

==========
removed

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Extensions] Remove FeatureSwitch::easy_off_store_install

The "easy off-store install" switch is used to determine whether or not
chrome will automatically install an extension that isn't hosted in the
webstore if the user downloads it. However, this has been disabled on
all platforms, and has no associated commandline switch or flag, so it
is permanently disabled. The only usages are in tests.

Remove the feature switch and add a lighter-weight test function to
accommodate.

BUG=687623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2017-02-01 17:15:52]

Description was changed from

==========
[Extensions] Remove FeatureSwitch::easy_off_store_install

The "easy off-store install" switch is used to determine whether or not
chrome will automatically install an extension that isn't hosted in the
webstore if the user downloads it. However, this has been disabled on
all platforms, and has no associated commandline switch or flag, so it
is permanently disabled. The only usages are in tests.

Remove the feature switch and add a lighter-weight test function to
accommodate.

BUG=687623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Extensions] Remove FeatureSwitch::easy_off_store_install

The "easy off-store install" switch is used to determine whether or not
chrome will automatically install an extension that isn't hosted in the
webstore if the user downloads it. However, this has been disabled on
all platforms, and has no associated commandline switch or flag, so it
is permanently disabled. The only usages are in tests.

Remove the feature switch and add a lighter-weight test function to
accommodate.

Also re-enable an effectively-disabled extension browsertest (which only
ran when the easy off-store install switch was enabled - and that was
never true).

BUG=687623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2017-02-01 17:17:42]

rdevlin.cronin@chromium.org changed reviewers:
+ asanka@chromium.org, dbeam@chromium.org, lazyboy@chromium.org,
pastarmovj@chromium.org

[Devlin, 2017-02-01 17:17:43]

Hey folks, mind taking a look?
lazyboy: extensions
asanka: downloads
dbeam: resources, webui
pastarmovj: question in download_crx_util.cc

Cheers!

https://codereview.chromium.org/2668863002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_crx_util.cc (right):

https://codereview.chromium.org/2668863002/diff/20001/chrome/browser/download...
chrome/browser/download/download_crx_util.cc:136: return
g_allow_offstore_install_for_testing ||
pastarmovj@: I'd rather just have tests set the preference that the management
policy uses, which is pref_names::kAllowedInstallSites.  Unfortunately, this is
a managed preference, and I can't figure out any sane way to set a managed pref
in a browser test*.  Any advice here?  Is there an easy way of doing this?

*I know there's TestingPrefService, but that's not really compatible with our
browser test structure, which sets up a real profile and pref service.

[lazyboy, 2017-02-01 20:12:13]

lgtm

https://codereview.chromium.org/2668863002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/crx_installer.cc (right):

https://codereview.chromium.org/2668863002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/crx_installer.cc:330: // should either add them to
histograms.xml or delete them.
We should also consider dropping the "Hard" suffix since it is hard to
understand now as we don't have the "Easy" case anymore. Either remove the
suffix or add the note to this TODO.

[asanka, 2017-02-01 22:36:12]

/download/ lgtm

[Dan Beam, 2017-02-02 07:00:57]

lgtm

[Devlin, 2017-02-06 17:22:33]

https://codereview.chromium.org/2668863002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_crx_util.cc (right):

https://codereview.chromium.org/2668863002/diff/20001/chrome/browser/download...
chrome/browser/download/download_crx_util.cc:136: return
g_allow_offstore_install_for_testing ||
On 2017/02/01 17:17:42, Devlin wrote:
> pastarmovj@: I'd rather just have tests set the preference that the management
> policy uses, which is pref_names::kAllowedInstallSites.  Unfortunately, this
is
> a managed preference, and I can't figure out any sane way to set a managed
pref
> in a browser test*.  Any advice here?  Is there an easy way of doing this?
> 
> *I know there's TestingPrefService, but that's not really compatible with our
> browser test structure, which sets up a real profile and pref service.

Since this is still better than the current complexity, I'll address this in a
followup.  pastarmovj@, feel free to respond, and I'll clean it up if there's a
good solution. :)

[Devlin, 2017-02-06 17:22:36]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-02-06 17:23:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:22:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486401756870510,
"parent_rev": "5e1853ae12070c8d0f00c9f9ac4ab0ce4cc4fd30", "commit_rev":
"10f3454a3b79fc102ebb1b71e48bedf790eaccba"}

[commit-bot: I haz the power, 2017-02-06 18:23:33]

Description was changed from

==========
[Extensions] Remove FeatureSwitch::easy_off_store_install

The "easy off-store install" switch is used to determine whether or not
chrome will automatically install an extension that isn't hosted in the
webstore if the user downloads it. However, this has been disabled on
all platforms, and has no associated commandline switch or flag, so it
is permanently disabled. The only usages are in tests.

Remove the feature switch and add a lighter-weight test function to
accommodate.

Also re-enable an effectively-disabled extension browsertest (which only
ran when the easy off-store install switch was enabled - and that was
never true).

BUG=687623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Extensions] Remove FeatureSwitch::easy_off_store_install

The "easy off-store install" switch is used to determine whether or not
chrome will automatically install an extension that isn't hosted in the
webstore if the user downloads it. However, this has been disabled on
all platforms, and has no associated commandline switch or flag, so it
is permanently disabled. The only usages are in tests.

Remove the feature switch and add a lighter-weight test function to
accommodate.

Also re-enable an effectively-disabled extension browsertest (which only
ran when the easy off-store install switch was enabled - and that was
never true).

BUG=687623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668863002
Cr-Commit-Position: refs/heads/master@{#448311}
Committed:
https://chromium.googlesource.com/chromium/src/+/10f3454a3b79fc102ebb1b71e48b...
==========

[commit-bot: I haz the power, 2017-02-06 18:23:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/10f3454a3b79fc102ebb1b71e48b...

[pastarmovj, 2017-02-07 06:49:06]

https://codereview.chromium.org/2668863002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_crx_util.cc (right):

https://codereview.chromium.org/2668863002/diff/20001/chrome/browser/download...
chrome/browser/download/download_crx_util.cc:136: return
g_allow_offstore_install_for_testing ||
On 2017/02/06 17:22:33, Devlin wrote:
> On 2017/02/01 17:17:42, Devlin wrote:
> > pastarmovj@: I'd rather just have tests set the preference that the
management
> > policy uses, which is pref_names::kAllowedInstallSites.  Unfortunately, this
> is
> > a managed preference, and I can't figure out any sane way to set a managed
> pref
> > in a browser test*.  Any advice here?  Is there an easy way of doing this?
> > 
> > *I know there's TestingPrefService, but that's not really compatible with
our
> > browser test structure, which sets up a real profile and pref service.
> 
> Since this is still better than the current complexity, I'll address this in a
> followup.  pastarmovj@, feel free to respond, and I'll clean it up if there's
a
> good solution. :)

Hey sorry I somehow missed this request. You can check how we set policies for
the policy browser tests here
https://cs.chromium.org/chromium/src/chrome/browser/policy/policy_browsertest...
I hope this can be helpful for mocking this state.