[Extensions] Remove FeatureSwitch::easy_off_store_install

chrome/browser/download/download_crx_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download code which handles CRX files (extensions, themes, apps, ...).
 
 #include "chrome/browser/download/download_crx_util.h"
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_management.h"
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/user_script.h"
 
 using content::BrowserThread;
 using content::DownloadItem;
 using extensions::WebstoreInstaller;
 
 namespace download_crx_util {
 
 namespace {
 
+bool g_allow_offstore_install_for_testing = false;
+
 // Hold a mock ExtensionInstallPrompt object that will be used when the
 // download system opens a CRX.
 ExtensionInstallPrompt* mock_install_prompt_for_testing = NULL;
 
 // Called to get an extension install UI object.  In tests, will return
 // a mock if the test calls download_util::SetMockInstallPromptForTesting()
 // to set one.
 std::unique_ptr<ExtensionInstallPrompt> CreateExtensionInstallPrompt(
     Profile* profile,
     const DownloadItem& download_item) {
@@ skipping 84 matching lines @@
     return true;
   } else {
     return false;
   }
 }
 
 bool OffStoreInstallAllowedByPrefs(Profile* profile, const DownloadItem& item) {
   // TODO(aa): RefererURL is cleared in some cases, for example when going
   // between secure and non-secure URLs. It would be better if DownloadItem
   // tracked the initiating page explicitly.
-  return extensions::ExtensionManagementFactory::GetForBrowserContext(profile)
-      ->IsOffstoreInstallAllowed(item.GetURL(), item.GetReferrerUrl());
+  return g_allow_offstore_install_for_testing ||

[Devlin, 2017/02/01 17:17:42]

pastarmovj@: I'd rather just have tests set the preference that the management
policy uses, which is pref_names::kAllowedInstallSites.  Unfortunately, this is
a managed preference, and I can't figure out any sane way to set a managed pref
in a browser test*.  Any advice here?  Is there an easy way of doing this?

*I know there's TestingPrefService, but that's not really compatible with our
browser test structure, which sets up a real profile and pref service.

[Devlin, 2017/02/06 17:22:33]

Since this is still better than the current complexity, I'll address this in a
followup.  pastarmovj@, feel free to respond, and I'll clean it up if there's a
good solution. :)

[pastarmovj, 2017/02/07 06:49:06]

Hey sorry I somehow missed this request. You can check how we set policies for
the policy browser tests here
https://cs.chromium.org/chromium/src/chrome/browser/policy/policy_browsertest...
I hope this can be helpful for mocking this state.

+         extensions::ExtensionManagementFactory::GetForBrowserContext(profile)
+             ->IsOffstoreInstallAllowed(item.GetURL(), item.GetReferrerUrl());
+}
+
+std::unique_ptr<base::AutoReset<bool>> OverrideOffstoreInstallAllowedForTesting(
+    bool allowed) {
+  return base::MakeUnique<base::AutoReset<bool>>(
+      &g_allow_offstore_install_for_testing, allowed);
 }
 
 }  // namespace download_crx_util