[Extensions] Remove FeatureSwitch::easy_off_store_install

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 #include <utility>
 
@@ skipping 31 matching lines @@
 #include "content/public/browser/resource_dispatcher_host.h"
 #include "content/public/browser/user_metrics.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/install/crx_install_error.h"
 #include "extensions/browser/install/extension_install_ui.h"
 #include "extensions/browser/install_flag.h"
 #include "extensions/browser/notification_types.h"
 #include "extensions/common/extension_icon_set.h"
-#include "extensions/common/feature_switch.h"
 #include "extensions/common/file_util.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_handlers/kiosk_mode_info.h"
 #include "extensions/common/manifest_handlers/shared_module_info.h"
 #include "extensions/common/manifest_url_handlers.h"
 #include "extensions/common/permissions/permission_message_provider.h"
 #include "extensions/common/permissions/permission_set.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/common/user_script.h"
 #include "extensions/strings/grit/extensions_strings.h"
@@ skipping 257 matching lines @@
     return CrxInstallError();
   }
 
   if (!extensions_enabled_) {
     return CrxInstallError(
         CrxInstallError::ERROR_DECLINED,
         l10n_util::GetStringUTF16(IDS_EXTENSION_INSTALL_NOT_ENABLED));
   }
 
   if (install_cause_ == extension_misc::INSTALL_CAUSE_USER_DOWNLOAD) {
-    if (FeatureSwitch::easy_off_store_install()->IsEnabled()) {
-      const char kHistogramName[] = "Extensions.OffStoreInstallDecisionEasy";
-      if (is_gallery_install()) {
-        UMA_HISTOGRAM_ENUMERATION(kHistogramName, OnStoreInstall,
-                                  NumOffStoreInstallDecision);
-      } else {
-        UMA_HISTOGRAM_ENUMERATION(kHistogramName, OffStoreInstallAllowed,
-                                  NumOffStoreInstallDecision);
-      }
+    // TODO(devlin): It appears that these histograms are never logged. We
+    // should either add them to histograms.xml or delete them.

[lazyboy, 2017/02/01 20:12:13]

We should also consider dropping the "Hard" suffix since it is hard to
understand now as we don't have the "Easy" case anymore. Either remove the
suffix or add the note to this TODO.

+    const char kHistogramName[] = "Extensions.OffStoreInstallDecisionHard";
+    if (is_gallery_install()) {
+      UMA_HISTOGRAM_ENUMERATION(kHistogramName,
+                                OffStoreInstallDecision::OnStoreInstall,
+                                NumOffStoreInstallDecision);
+    } else if (off_store_install_allow_reason_ != OffStoreInstallDisallowed) {
+      UMA_HISTOGRAM_ENUMERATION(kHistogramName,
+                                OffStoreInstallDecision::OffStoreInstallAllowed,
+                                NumOffStoreInstallDecision);
+      UMA_HISTOGRAM_ENUMERATION("Extensions.OffStoreInstallAllowReason",
+                                off_store_install_allow_reason_,
+                                NumOffStoreInstallAllowReasons);
     } else {
-      const char kHistogramName[] = "Extensions.OffStoreInstallDecisionHard";
-      if (is_gallery_install()) {
-        UMA_HISTOGRAM_ENUMERATION(kHistogramName,
-                                  OffStoreInstallDecision::OnStoreInstall,
-                                  NumOffStoreInstallDecision);
-      } else if (off_store_install_allow_reason_ != OffStoreInstallDisallowed) {
-        UMA_HISTOGRAM_ENUMERATION(
-            kHistogramName, OffStoreInstallDecision::OffStoreInstallAllowed,
-            NumOffStoreInstallDecision);
-        UMA_HISTOGRAM_ENUMERATION("Extensions.OffStoreInstallAllowReason",
-                                  off_store_install_allow_reason_,
-                                  NumOffStoreInstallAllowReasons);
-      } else {
-        UMA_HISTOGRAM_ENUMERATION(
-            kHistogramName, OffStoreInstallDecision::OffStoreInstallDisallowed,
-            NumOffStoreInstallDecision);
-        // Don't delete source in this case so that the user can install
-        // manually if they want.
-        delete_source_ = false;
-        did_handle_successfully_ = false;
+      UMA_HISTOGRAM_ENUMERATION(
+          kHistogramName, OffStoreInstallDecision::OffStoreInstallDisallowed,
+          NumOffStoreInstallDecision);
+      // Don't delete source in this case so that the user can install
+      // manually if they want.
+      delete_source_ = false;
+      did_handle_successfully_ = false;
 
-        return CrxInstallError(CrxInstallError::ERROR_OFF_STORE,
-                               l10n_util::GetStringUTF16(
-                                   IDS_EXTENSION_INSTALL_DISALLOWED_ON_SITE));
-      }
+      return CrxInstallError(
+          CrxInstallError::ERROR_OFF_STORE,
+          l10n_util::GetStringUTF16(IDS_EXTENSION_INSTALL_DISALLOWED_ON_SITE));
     }
   }
 
   if (install_checker_.extension()->is_app()) {
     // If the app was downloaded, apps_require_extension_mime_type_
     // will be set.  In this case, check that it was served with the
     // right mime type.  Make an exception for file URLs, which come
     // from the users computer and have no headers.
     if (!download_url_.SchemeIsFile() &&
         apps_require_extension_mime_type_ &&
@@ skipping 543 matching lines @@
         ExtensionInstallPrompt::GetReEnablePromptTypeForExtension(
             service->profile(), extension());
     client_->ShowDialog(base::Bind(&CrxInstaller::OnInstallPromptDone, this),
                         extension(), nullptr,
                         base::MakeUnique<ExtensionInstallPrompt::Prompt>(type),
                         ExtensionInstallPrompt::GetDefaultShowDialogCallback());
   }
 }
 
 }  // namespace extensions