Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2668813003: Making the warning message more clear and adding an error message when the script actually gets blo… (Closed)

Created:
3 years, 10 months ago by shivanisha
Modified:
3 years, 10 months ago
Reviewers:
Bryan McQuade
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, loading-reviews+parser_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Making the warning message more clear and adding an error message when the script actually gets blocked and a warning message if the script is not blocked due to cache hit. BUG=658983 Review-Url: https://codereview.chromium.org/2640163002 Cr-Commit-Position: refs/heads/master@{#447018} (cherry picked from commit 13905c2317d62f3f657e7463aa58c093567dd1cc) TBR=bmcquade@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2668813003 Cr-Commit-Position: refs/branch-heads/2987@{#247} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/5a01a9745dcc4eefd77725448cd279b94ad00eb0

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
shivanisha
3 years, 10 months ago (2017-02-01 16:13:38 UTC) #1
Bryan McQuade
lgtm
3 years, 10 months ago (2017-02-01 16:25:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668813003/1
3 years, 10 months ago (2017-02-01 16:26:45 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 16:28:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a01a9745dcc4eefd77725448cd2...

Powered by Google App Engine
This is Rietveld 408576698