|
|
Created:
3 years, 11 months ago by shivanisha Modified:
3 years, 8 months ago CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, loading-reviews+parser_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMaking the warning message more clear and adding an error message when the script actually gets blocked and a warning message if the script is not blocked due to cache hit.
BUG=658983
Review-Url: https://codereview.chromium.org/2640163002
Cr-Commit-Position: refs/heads/master@{#447018}
Committed: https://chromium.googlesource.com/chromium/src/+/13905c2317d62f3f657e7463aa58c093567dd1cc
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebased till refs/heads/master@{#444758} #Patch Set 3 : Updated messages with feedback. #Patch Set 4 : Tests output modified #Patch Set 5 : More message edits. #Patch Set 6 : Updated tests #
Total comments: 6
Patch Set 7 : Feedback incorporated. #
Total comments: 2
Depends on Patchset: Messages
Total messages: 54 (36 generated)
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shivanisha@chromium.org changed reviewers: + bmcquade@chromium.org, japhet@chromium.org
PTAL, Thanks! Trying to land it today for branch cut.
LGTM, thanks!
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for more details. If the script is indeed blocked, you should see an " thinking about this more i'm a little concerned that devs might interpret this last sentence as "if i don't see the subsequent error, my page isn't affected by this issue" and they won't fix their page, so I'm inclined to omit this last "If the script is indeed blocked..." text. We can make it clear in the linked documentation that this message is a warning and only if you see the additional 'script was blocked' message was there an actual issue. Given this, can we remove this last sentence?
Retrying the failed bots. If not successful, will try for a merge after branch cut.
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Making the warning message more clear and adding an error message when the script actually gets blocked and a warning message if the script is not blocked due to cache hit. ========== to ========== Making the warning message more clear and adding an error message when the script actually gets blocked and a warning message if the script is not blocked due to cache hit. BUG=658983 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for more details. If the script is indeed blocked, you should see an " On 2017/01/18 at 23:47:04, Bryan McQuade wrote: > thinking about this more i'm a little concerned that devs might interpret this last sentence as "if i don't see the subsequent error, my page isn't affected by this issue" and they won't fix their page, so I'm inclined to omit this last "If the script is indeed blocked..." text. We can make it clear in the linked documentation that this message is a warning and only if you see the additional 'script was blocked' message was there an actual issue. > > Given this, can we remove this last sentence? I hear your concern. Omitting the last sentence might still leave users unsure whether it actually was blocked or not, in case they do not read the link very carefully. How about something like this: "A Parser-blocking, cross site (i.e. different eTLD+1) script http://ajax.cloudflare.com/cdn-cgi/nexp/dok3v=f2befc48d1/cloudflare.min.js, is invoked via document.write. This MAY be blocked by the browser in this or a future page load due to poor network connectivity. If blocked in this page load, it will be confirmed in a subsequent ERROR message. See https://www.chromestatus.com/feature/5718547946799104 for more details."
That sounds good, thanks! Only suggestion would be to drop 'ERROR' as I am not sure users will know what that means - just 'subsequent message' seems sufficient here. Or maybe 'subsequent console message'. Thanks! On Thu, Jan 19, 2017 at 1:04 PM <shivanisha@chromium.org> wrote: > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp > (right): > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for > more details. If the script is indeed blocked, you should see an " > On 2017/01/18 at 23:47:04, Bryan McQuade wrote: > > thinking about this more i'm a little concerned that devs might > interpret this last sentence as "if i don't see the subsequent error, my > page isn't affected by this issue" and they won't fix their page, so I'm > inclined to omit this last "If the script is indeed blocked..." text. We > can make it clear in the linked documentation that this message is a > warning and only if you see the additional 'script was blocked' message > was there an actual issue. > > > > Given this, can we remove this last sentence? > > I hear your concern. Omitting the last sentence might still leave users > unsure whether it actually was blocked or not, in case they do not read > the link very carefully. How about something like this: > > "A Parser-blocking, cross site (i.e. different eTLD+1) script > http://ajax.cloudflare.com/cdn-cgi/nexp/dok3v=f2befc48d1/cloudflare.min.js > , > is invoked via document.write. This MAY be blocked by the browser in > this or a future page load due to poor network connectivity. If blocked > in this page load, it will be confirmed in a subsequent ERROR message. > See https://www.chromestatus.com/feature/5718547946799104 for more > details." > > https://codereview.chromium.org/2640163002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
That sounds good, thanks! Only suggestion would be to drop 'ERROR' as I am not sure users will know what that means - just 'subsequent message' seems sufficient here. Or maybe 'subsequent console message'. Thanks! On Thu, Jan 19, 2017 at 1:04 PM <shivanisha@chromium.org> wrote: > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp > (right): > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for > more details. If the script is indeed blocked, you should see an " > On 2017/01/18 at 23:47:04, Bryan McQuade wrote: > > thinking about this more i'm a little concerned that devs might > interpret this last sentence as "if i don't see the subsequent error, my > page isn't affected by this issue" and they won't fix their page, so I'm > inclined to omit this last "If the script is indeed blocked..." text. We > can make it clear in the linked documentation that this message is a > warning and only if you see the additional 'script was blocked' message > was there an actual issue. > > > > Given this, can we remove this last sentence? > > I hear your concern. Omitting the last sentence might still leave users > unsure whether it actually was blocked or not, in case they do not read > the link very carefully. How about something like this: > > "A Parser-blocking, cross site (i.e. different eTLD+1) script > http://ajax.cloudflare.com/cdn-cgi/nexp/dok3v=f2befc48d1/cloudflare.min.js > , > is invoked via document.write. This MAY be blocked by the browser in > this or a future page load due to poor network connectivity. If blocked > in this page load, it will be confirmed in a subsequent ERROR message. > See https://www.chromestatus.com/feature/5718547946799104 for more > details." > > https://codereview.chromium.org/2640163002/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/19 at 18:08:04, bmcquade wrote: > That sounds good, thanks! Only suggestion would be to drop 'ERROR' as I am > not sure users will know what that means - just 'subsequent message' seems > sufficient here. Or maybe 'subsequent console message'. > > Thanks! Done. Thanks! > > On Thu, Jan 19, 2017 at 1:04 PM <shivanisha@chromium.org> wrote: > > > > > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > > File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp > > (right): > > > > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > > third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for > > more details. If the script is indeed blocked, you should see an " > > On 2017/01/18 at 23:47:04, Bryan McQuade wrote: > > > thinking about this more i'm a little concerned that devs might > > interpret this last sentence as "if i don't see the subsequent error, my > > page isn't affected by this issue" and they won't fix their page, so I'm > > inclined to omit this last "If the script is indeed blocked..." text. We > > can make it clear in the linked documentation that this message is a > > warning and only if you see the additional 'script was blocked' message > > was there an actual issue. > > > > > > Given this, can we remove this last sentence? > > > > I hear your concern. Omitting the last sentence might still leave users > > unsure whether it actually was blocked or not, in case they do not read > > the link very carefully. How about something like this: > > > > "A Parser-blocking, cross site (i.e. different eTLD+1) script > > http://ajax.cloudflare.com/cdn-cgi/nexp/dok3v=f2befc48d1/cloudflare.min.js > > , > > is invoked via document.write. This MAY be blocked by the browser in > > this or a future page load due to poor network connectivity. If blocked > > in this page load, it will be confirmed in a subsequent ERROR message. > > See https://www.chromestatus.com/feature/5718547946799104 for more > > details." > > > > https://codereview.chromium.org/2640163002/ > > > > -- > You received this message because you are subscribed to the Google Groups "Blink Reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org. >
The CQ bit was unchecked by shivanisha@chromium.org
On 2017/01/24 at 16:16:09, shivanisha wrote: > On 2017/01/19 at 18:08:04, bmcquade wrote: > > That sounds good, thanks! Only suggestion would be to drop 'ERROR' as I am > > not sure users will know what that means - just 'subsequent message' seems > > sufficient here. Or maybe 'subsequent console message'. > > > > Thanks! > > Done. Thanks! > > > > > On Thu, Jan 19, 2017 at 1:04 PM <shivanisha@chromium.org> wrote: > > > > > > > > > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > > > File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp > > > (right): > > > > > > > > > https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/c... > > > third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for > > > more details. If the script is indeed blocked, you should see an " > > > On 2017/01/18 at 23:47:04, Bryan McQuade wrote: > > > > thinking about this more i'm a little concerned that devs might > > > interpret this last sentence as "if i don't see the subsequent error, my > > > page isn't affected by this issue" and they won't fix their page, so I'm > > > inclined to omit this last "If the script is indeed blocked..." text. We > > > can make it clear in the linked documentation that this message is a > > > warning and only if you see the additional 'script was blocked' message > > > was there an actual issue. > > > > > > > > Given this, can we remove this last sentence? > > > > > > I hear your concern. Omitting the last sentence might still leave users > > > unsure whether it actually was blocked or not, in case they do not read > > > the link very carefully. How about something like this: > > > > > > "A Parser-blocking, cross site (i.e. different eTLD+1) script > > > http://ajax.cloudflare.com/cdn-cgi/nexp/dok3v=f2befc48d1/cloudflare.min.js > > > , > > > is invoked via document.write. This MAY be blocked by the browser in > > > this or a future page load due to poor network connectivity. If blocked > > > in this page load, it will be confirmed in a subsequent ERROR message. > > > See https://www.chromestatus.com/feature/5718547946799104 for more > > > details." > > > > > > https://codereview.chromium.org/2640163002/ > > > > > > > -- > > You received this message because you are subscribed to the Google Groups "Blink Reviews" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org. > > Thanks! 2 small changes, otherwise LGTM.
Sorry, my earlier comments did not go through. Hope they come through this time. https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp (right): https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:272: "connectivity. See " do we already show the chromestatus link in the previous message? if so, i think we can drop it here. https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:287: "See https://www.chromestatus.com/feature/5718547946799104 " same https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "subsequent message." nit: maybe 'subsequent console message'? reading this now, message isn't totally clear - as a dev i might wonder what kind of message we are referring to.
https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp (right): https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:272: "connectivity. See " On 2017/01/24 at 16:45:26, Bryan McQuade wrote: > do we already show the chromestatus link in the previous message? if so, i think we can drop it here. Done. https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:287: "See https://www.chromestatus.com/feature/5718547946799104 " On 2017/01/24 at 16:45:26, Bryan McQuade wrote: > same Done. https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "subsequent message." On 2017/01/24 at 16:45:26, Bryan McQuade wrote: > nit: maybe 'subsequent console message'? reading this now, message isn't totally clear - as a dev i might wonder what kind of message we are referring to. Done.
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Some of the bot failures being tracked via https://bugs.chromium.org/p/chromium/issues/detail?id=684573 Once they are fixed, hopefully commit will proceed.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shivanisha@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org, bmcquade@chromium.org Link to the patchset: https://codereview.chromium.org/2640163002/#ps160001 (title: "Feedback incorporated.")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2474943002 Patch 120001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by shivanisha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 160001, "attempt_start_ts": 1485793455950910, "parent_rev": "90efe3450f9f29a5535bce77249d064b354ff378", "commit_rev": "13905c2317d62f3f657e7463aa58c093567dd1cc"}
Message was sent while issue was closed.
Description was changed from ========== Making the warning message more clear and adding an error message when the script actually gets blocked and a warning message if the script is not blocked due to cache hit. BUG=658983 ========== to ========== Making the warning message more clear and adding an error message when the script actually gets blocked and a warning message if the script is not blocked due to cache hit. BUG=658983 Review-Url: https://codereview.chromium.org/2640163002 Cr-Commit-Position: refs/heads/master@{#447018} Committed: https://chromium.googlesource.com/chromium/src/+/13905c2317d62f3f657e7463aa58... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:160001) as https://chromium.googlesource.com/chromium/src/+/13905c2317d62f3f657e7463aa58...
Message was sent while issue was closed.
https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp (right): https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:274: WTFLogAlways("%s", message.utf8().data()); Please do not use WTFLogAlways. It's deprecated.
Message was sent while issue was closed.
https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp (right): https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:274: WTFLogAlways("%s", message.utf8().data()); On 2017/04/04 at 04:12:35, tkent wrote: > Please do not use WTFLogAlways. It's deprecated. Thanks for pointing out. What is the recommended way to log? |