Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2640163002: Doc.write intervention warning and error messages fixed for clarity. (Closed)

Created:
3 years, 11 months ago by shivanisha
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, loading-reviews+parser_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making the warning message more clear and adding an error message when the script actually gets blocked and a warning message if the script is not blocked due to cache hit. BUG=658983 Review-Url: https://codereview.chromium.org/2640163002 Cr-Commit-Position: refs/heads/master@{#447018} Committed: https://chromium.googlesource.com/chromium/src/+/13905c2317d62f3f657e7463aa58c093567dd1cc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased till refs/heads/master@{#444758} #

Patch Set 3 : Updated messages with feedback. #

Patch Set 4 : Tests output modified #

Patch Set 5 : More message edits. #

Patch Set 6 : Updated tests #

Total comments: 6

Patch Set 7 : Feedback incorporated. #

Total comments: 2

Messages

Total messages: 54 (36 generated)
shivanisha
PTAL, Thanks! Trying to land it today for branch cut.
3 years, 11 months ago (2017-01-18 21:07:32 UTC) #4
Bryan McQuade
LGTM, thanks!
3 years, 11 months ago (2017-01-18 21:13:29 UTC) #5
Nate Chapin
lgtm
3 years, 11 months ago (2017-01-18 22:15:03 UTC) #6
Bryan McQuade
https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp#newcode96 third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for more details. If the script is indeed blocked, ...
3 years, 11 months ago (2017-01-18 23:47:04 UTC) #9
shivanisha
Retrying the failed bots. If not successful, will try for a merge after branch cut.
3 years, 11 months ago (2017-01-18 23:59:39 UTC) #10
shivanisha
https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right): https://codereview.chromium.org/2640163002/diff/1/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp#newcode96 third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:96: "for more details. If the script is indeed blocked, ...
3 years, 11 months ago (2017-01-19 18:04:59 UTC) #27
Bryan McQuade
That sounds good, thanks! Only suggestion would be to drop 'ERROR' as I am not ...
3 years, 11 months ago (2017-01-19 18:08:04 UTC) #28
Bryan McQuade
That sounds good, thanks! Only suggestion would be to drop 'ERROR' as I am not ...
3 years, 11 months ago (2017-01-19 18:08:04 UTC) #29
shivanisha
On 2017/01/19 at 18:08:04, bmcquade wrote: > That sounds good, thanks! Only suggestion would be ...
3 years, 11 months ago (2017-01-24 16:16:09 UTC) #34
Bryan McQuade
On 2017/01/24 at 16:16:09, shivanisha wrote: > On 2017/01/19 at 18:08:04, bmcquade wrote: > > ...
3 years, 11 months ago (2017-01-24 16:39:14 UTC) #36
Bryan McQuade
Sorry, my earlier comments did not go through. Hope they come through this time. https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp ...
3 years, 11 months ago (2017-01-24 16:45:26 UTC) #37
shivanisha
https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp File third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp (right): https://codereview.chromium.org/2640163002/diff/140001/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp#newcode272 third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:272: "connectivity. See " On 2017/01/24 at 16:45:26, Bryan McQuade ...
3 years, 11 months ago (2017-01-24 17:22:38 UTC) #38
shivanisha
Some of the bot failures being tracked via https://bugs.chromium.org/p/chromium/issues/detail?id=684573 Once they are fixed, hopefully commit ...
3 years, 11 months ago (2017-01-24 18:00:29 UTC) #41
commit-bot: I haz the power
This CL has an open dependency (Issue 2474943002 Patch 120001). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-25 20:27:57 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640163002/160001
3 years, 10 months ago (2017-01-30 16:24:45 UTC) #49
commit-bot: I haz the power
Committed patchset #7 (id:160001) as https://chromium.googlesource.com/chromium/src/+/13905c2317d62f3f657e7463aa58c093567dd1cc
3 years, 10 months ago (2017-01-30 18:37:52 UTC) #52
tkent
https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp File third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp (right): https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp#newcode274 third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:274: WTFLogAlways("%s", message.utf8().data()); Please do not use WTFLogAlways. It's deprecated.
3 years, 8 months ago (2017-04-04 04:12:35 UTC) #53
shivanisha
3 years, 8 months ago (2017-04-04 14:24:18 UTC) #54
Message was sent while issue was closed.
https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
(right):

https://codereview.chromium.org/2640163002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp:274:
WTFLogAlways("%s", message.utf8().data());
On 2017/04/04 at 04:12:35, tkent wrote:
> Please do not use WTFLogAlways.  It's deprecated.

Thanks for pointing out. What is the recommended way to log?

Powered by Google App Engine
This is Rietveld 408576698