Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2668813003: Making the warning message more clear and adding an error message when the script actually gets blo… (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index a3321e4ce432278bde79d780913b7a87682e2510..e5c7ff324fb28ee22ee731f13ed22a15e336a707 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -91,8 +91,10 @@ namespace {
void emitWarningForDocWriteScripts(const String& url, Document& document) {
String message =
"A Parser-blocking, cross site (i.e. different eTLD+1) script, " + url +
- ", is invoked via document.write. This may be blocked by "
- "the browser if the device has poor network connectivity. "
+ ", is invoked via document.write. This MAY be blocked by "
+ "the browser in this or a future page load due to poor network "
+ "connectivity. If blocked in this page load, it will be confirmed in a "
+ "subsequent console message."
"See https://www.chromestatus.com/feature/5718547946799104 "
"for more details.";
document.addConsoleMessage(
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698