Convert ExtensionOptionsGuest to use the new navigation callbacks.

Convert ExtensionOptionsGuest to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2668773003
Cr-Commit-Position: refs/heads/master@{#447547}
Committed: https://chromium.googlesource.com/chromium/src/+/16590d19332f9b22bba61b8bd215d136ed1fc311

[jam, 2017-02-01 05:05:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-02-01 05:05:22]

Description was changed from

==========
Convert ExtensionOptionsGuest to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ExtensionOptionsGuest to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-02-01 05:05:22]

jam@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-02-01 05:05:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 06:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 06:04:52]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-02-01 16:11:06]

lgtm

https://codereview.chromium.org/2668773003/diff/1/extensions/browser/guest_vi...
File extensions/browser/guest_view/extension_options/extension_options_guest.cc
(right):

https://codereview.chromium.org/2668773003/diff/1/extensions/browser/guest_vi...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:228:
if (attached()) {
nit: maybe combine this with the if above?
if (!navigation_handle->IsInMainFrame() ||
    !navigation_handle->HasCommitted() ||
    !attached())
  return;

[jam, 2017-02-01 16:22:09]

https://codereview.chromium.org/2668773003/diff/1/extensions/browser/guest_vi...
File extensions/browser/guest_view/extension_options/extension_options_guest.cc
(right):

https://codereview.chromium.org/2668773003/diff/1/extensions/browser/guest_vi...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:228:
if (attached()) {
On 2017/02/01 16:11:06, Devlin wrote:
> nit: maybe combine this with the if above?
> if (!navigation_handle->IsInMainFrame() ||
>     !navigation_handle->HasCommitted() ||
>     !attached())
>   return;

Done.

[jam, 2017-02-01 16:22:21]

The CQ bit was checked by jam@chromium.org

[jam, 2017-02-01 16:22:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2668773003/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-02-01 16:22:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 17:22:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485966141174050,
"parent_rev": "6e0361b43828f6ed6f6b31e451bf2573a5dd012a", "commit_rev":
"16590d19332f9b22bba61b8bd215d136ed1fc311"}

[commit-bot: I haz the power, 2017-02-01 17:23:18]

Description was changed from

==========
Convert ExtensionOptionsGuest to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ExtensionOptionsGuest to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2668773003
Cr-Commit-Position: refs/heads/master@{#447547}
Committed:
https://chromium.googlesource.com/chromium/src/+/16590d19332f9b22bba61b8bd215...
==========

[commit-bot: I haz the power, 2017-02-01 17:23:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16590d19332f9b22bba61b8bd215...