Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 2668773003: Convert ExtensionOptionsGuest to use the new navigation callbacks. (Closed)
Patch Set: nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/extension_options/extension_options_guest.h
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h
index 5b0505c9b1d681bebd402e231c99f858c666f0e1..b3b714e4d077cb67e85438e37b4ec7bc545e2c2c 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h
@@ -57,8 +57,7 @@ class ExtensionOptionsGuest
content::SessionStorageNamespace* session_storage_namespace) final;
// content::WebContentsObserver implementation.
- void DidNavigateMainFrame(const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) final;
+ void DidFinishNavigation(content::NavigationHandle* navigation_handle) final;
std::unique_ptr<extensions::ExtensionOptionsGuestDelegate>
extension_options_guest_delegate_;
« no previous file with comments | « no previous file | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698