Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 2668773003: Convert ExtensionOptionsGuest to use the new navigation callbacks. (Closed)
Patch Set: nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_ 5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_
6 #define EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_ 6 #define EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 int32_t main_frame_route_id, 50 int32_t main_frame_route_id,
51 int32_t main_frame_widget_route_id, 51 int32_t main_frame_widget_route_id,
52 WindowContainerType window_container_type, 52 WindowContainerType window_container_type,
53 const GURL& opener_url, 53 const GURL& opener_url,
54 const std::string& frame_name, 54 const std::string& frame_name,
55 const GURL& target_url, 55 const GURL& target_url,
56 const std::string& partition_id, 56 const std::string& partition_id,
57 content::SessionStorageNamespace* session_storage_namespace) final; 57 content::SessionStorageNamespace* session_storage_namespace) final;
58 58
59 // content::WebContentsObserver implementation. 59 // content::WebContentsObserver implementation.
60 void DidNavigateMainFrame(const content::LoadCommittedDetails& details, 60 void DidFinishNavigation(content::NavigationHandle* navigation_handle) final;
61 const content::FrameNavigateParams& params) final;
62 61
63 std::unique_ptr<extensions::ExtensionOptionsGuestDelegate> 62 std::unique_ptr<extensions::ExtensionOptionsGuestDelegate>
64 extension_options_guest_delegate_; 63 extension_options_guest_delegate_;
65 GURL options_page_; 64 GURL options_page_;
66 65
67 DISALLOW_COPY_AND_ASSIGN(ExtensionOptionsGuest); 66 DISALLOW_COPY_AND_ASSIGN(ExtensionOptionsGuest);
68 }; 67 };
69 68
70 } // namespace extensions 69 } // namespace extensions
71 70
72 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUE ST_H_ 71 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUE ST_H_
OLDNEW
« no previous file with comments | « no previous file | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698