Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2668393002: Rename DemuxerStreamProvider into MediaResource (Closed)

Created:
3 years, 10 months ago by servolk
Modified:
3 years, 10 months ago
Reviewers:
xhwang, tguilbert, slan
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, yzshen+watch_chromium.org, apacible+watch_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, lcwu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, halliwell+watch_chromium.org, xjz+watch_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, alokp+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, darin (slow to review), erickung+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DemuxerStreamProvider into MediaResource Review-Url: https://codereview.chromium.org/2668393002 Cr-Commit-Position: refs/heads/master@{#447700} Committed: https://chromium.googlesource.com/chromium/src/+/cfc91f159f1635c66d0e2f82ba4039c024019e97

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -582 lines) Patch
M chromecast/media/service/cast_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/service/cast_renderer.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M content/browser/media/android/media_player_renderer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/android/media_player_renderer.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M content/renderer/media/android/media_player_renderer_client.h View 3 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/media/android/media_player_renderer_client.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/base/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/demuxer.h View 2 chunks +2 lines, -2 lines 0 comments Download
D media/base/demuxer_stream_provider.h View 1 chunk +0 lines, -68 lines 0 comments Download
D media/base/demuxer_stream_provider.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M media/base/fake_demuxer_stream.h View 2 chunks +8 lines, -8 lines 0 comments Download
M media/base/fake_demuxer_stream.cc View 1 chunk +6 lines, -9 lines 0 comments Download
A + media/base/media_resource.h View 3 chunks +13 lines, -19 lines 1 comment Download
A + media/base/media_resource.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/base/media_url_demuxer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/media_url_demuxer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/media_url_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mock_filters.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/renderer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M media/mojo/clients/mojo_renderer.h View 1 5 chunks +9 lines, -9 lines 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 1 5 chunks +10 lines, -12 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D media/mojo/services/demuxer_stream_provider_shim.h View 1 1 chunk +0 lines, -55 lines 0 comments Download
D media/mojo/services/demuxer_stream_provider_shim.cc View 1 1 chunk +0 lines, -51 lines 0 comments Download
A + media/mojo/services/media_resource_shim.h View 1 2 chunks +12 lines, -12 lines 0 comments Download
A + media/mojo/services/media_resource_shim.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M media/remoting/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M media/remoting/courier_renderer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/remoting/courier_renderer.cc View 1 7 chunks +10 lines, -9 lines 0 comments Download
M media/remoting/courier_renderer_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M media/remoting/demuxer_stream_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D media/remoting/fake_demuxer_stream_provider.h View 1 chunk +0 lines, -69 lines 0 comments Download
D media/remoting/fake_demuxer_stream_provider.cc View 1 chunk +0 lines, -116 lines 0 comments Download
A + media/remoting/fake_media_resource.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + media/remoting/fake_media_resource.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/renderers/renderer_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/renderers/renderer_impl.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 2 chunks +14 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
servolk
3 years, 10 months ago (2017-02-02 00:15:00 UTC) #9
servolk
3 years, 10 months ago (2017-02-02 00:15:42 UTC) #11
tguilbert
LGTM
3 years, 10 months ago (2017-02-02 00:26:17 UTC) #12
xhwang
lgtm https://codereview.chromium.org/2668393002/diff/20001/media/base/media_resource.h File media/base/media_resource.h (right): https://codereview.chromium.org/2668393002/diff/20001/media/base/media_resource.h#newcode25 media/base/media_resource.h:25: STREAM, // Indicates GetStreams() should be used nit: ...
3 years, 10 months ago (2017-02-02 03:35:35 UTC) #15
slan
cast/ lgtm
3 years, 10 months ago (2017-02-02 03:44:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668393002/20001
3 years, 10 months ago (2017-02-02 04:08:00 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 05:12:43 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cfc91f159f1635c66d0e2f82ba40...

Powered by Google App Engine
This is Rietveld 408576698