Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2667283002: Refactor MediaResource to be multi-stream capable (Closed)

Created:
3 years, 10 months ago by servolk
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, apacible+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, halliwell+watch_chromium.org, alokp+watch_chromium.org, darin (slow to review), miu+watch_chromium.org, xjz+watch_chromium.org, erickung+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor MediaResource to be multi-stream capable Also move SetStreamStatusChangeCB to MediaResource

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -416 lines) Patch
M chromecast/media/cma/base/demuxer_stream_for_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/base/demuxer_stream_for_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chromecast/media/cma/test/frame_segmenter_for_test.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chromecast/media/service/cast_renderer.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M media/base/demuxer_perftest.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M media/base/demuxer_stream.h View 1 chunk +0 lines, -7 lines 0 comments Download
M media/base/fake_demuxer_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/fake_demuxer_stream.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M media/base/fake_text_track_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/fake_text_track_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/media_resource.h View 5 chunks +19 lines, -6 lines 0 comments Download
M media/base/media_url_demuxer.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/media_url_demuxer.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/pipeline_impl.cc View 2 chunks +17 lines, -16 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M media/filters/chunk_demuxer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 2 chunks +16 lines, -17 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 43 chunks +93 lines, -80 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/decrypting_demuxer_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 3 chunks +8 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 4 chunks +28 lines, -14 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 46 chunks +90 lines, -78 lines 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 2 chunks +11 lines, -24 lines 0 comments Download
M media/mojo/clients/mojo_renderer_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M media/mojo/services/media_resource_shim.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/services/media_resource_shim.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/remoting/courier_renderer.cc View 3 chunks +27 lines, -8 lines 0 comments Download
M media/remoting/fake_media_resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/remoting/fake_media_resource.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M media/renderers/renderer_impl.cc View 4 chunks +32 lines, -18 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 13 chunks +42 lines, -46 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 4 chunks +13 lines, -10 lines 0 comments Download

Depends on Patchset:

Issue 2668393002 Patch 20001

Messages

Total messages: 4 (4 generated)
servolk
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-02 00:07:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667283002/1
3 years, 10 months ago (2017-02-02 00:07:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-02 06:23:45 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 06:23:46 UTC) #4 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698