[inspector] removed unused code from JavaScriptSourceFrame

[inspector] removed unused code from JavaScriptSourceFrame

And fixed gcc compilation.

BUG=none
R=alph@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2668363002
Cr-Commit-Position: refs/heads/master@{#42895}
Committed: https://chromium.googlesource.com/v8/v8/+/5805526d375225604f91e3e0e96cd3e5ed7733d6

[kozy, 2017-02-01 19:30:33]

Description was changed from

==========
[inspector] remove unused code from JavaScriptSourceFrame

BUG=none
R=alph@chromium.org,dgozman@chromium.org
==========

to

==========
[inspector] removed unused code from JavaScriptSourceFrame

And fixed gcc compilation.

BUG=none
R=alph@chromium.org,dgozman@chromium.org
==========

[kozy, 2017-02-01 19:31:16]

Alexey or Dmitry, please take a look!

[kozy, 2017-02-01 19:32:05]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 19:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-02-01 19:55:49]

Patchset #2 (id:20001) has been deleted

[kozy, 2017-02-02 16:16:16]

kozyatinskiy@chromium.org changed reviewers:
+ luoe@chromium.org

[kozy, 2017-02-02 16:16:16]

Erik, please take a look.

[dgozman, 2017-02-02 17:22:19]

NIce! lgtm

https://codereview.chromium.org/2668363002/diff/1/src/inspector/wasm-translat...
File src/inspector/wasm-translation.cc (right):

https://codereview.chromium.org/2668363002/diff/1/src/inspector/wasm-translat...
src/inspector/wasm-translation.cc:64: Local<debug::WasmScript> script =
script_.Get(isolate);
How is Handle accessible in this code? Do we include something we should not?

[kozy, 2017-02-02 17:57:34]

thanks!

https://codereview.chromium.org/2668363002/diff/1/src/inspector/wasm-translat...
File src/inspector/wasm-translation.cc (right):

https://codereview.chromium.org/2668363002/diff/1/src/inspector/wasm-translat...
src/inspector/wasm-translation.cc:64: Local<debug::WasmScript> script =
script_.Get(isolate);
On 2017/02/02 17:22:18, dgozman_slow wrote:
> How is Handle accessible in this code? Do we include something we should not?

I found one suspicious dependency - src/conversions.h for double to string
conversions in string-16.cc. I could try to expose only needed methods via
debug-interface.h in followup.

[kozy, 2017-02-02 17:57:41]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-02 17:57:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 18:15:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486058261531950, "parent_rev":
"d07f6540c1f9628ed2ba1fa6507c90db07ccc5f5", "commit_rev":
"5805526d375225604f91e3e0e96cd3e5ed7733d6"}

[commit-bot: I haz the power, 2017-02-02 18:15:05]

Description was changed from

==========
[inspector] removed unused code from JavaScriptSourceFrame

And fixed gcc compilation.

BUG=none
R=alph@chromium.org,dgozman@chromium.org
==========

to

==========
[inspector] removed unused code from JavaScriptSourceFrame

And fixed gcc compilation.

BUG=none
R=alph@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2668363002
Cr-Commit-Position: refs/heads/master@{#42895}
Committed:
https://chromium.googlesource.com/v8/v8/+/5805526d375225604f91e3e0e96cd3e5ed7...
==========

[commit-bot: I haz the power, 2017-02-02 18:15:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5805526d375225604f91e3e0e96cd3e5ed7...