Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Issue 2674583002: [inspector] added missing test for console methods (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
ulan, alph, luoe
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added missing test for console methods - and removed ":" from the output of console.count without argument. BUG=none R=luoe@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2674583002 Cr-Commit-Position: refs/heads/master@{#42903} Committed: https://chromium.googlesource.com/v8/v8/+/a62322aadbe3807d923bb7c4f1f930788e808a2b

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+688 lines, -2 lines) Patch
M src/inspector/v8-console.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A test/inspector/runtime/console-methods.js View 1 chunk +36 lines, -0 lines 0 comments Download
A test/inspector/runtime/console-methods-expected.txt View 1 chunk +648 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kozy
Please take a look!
3 years, 10 months ago (2017-02-02 01:48:09 UTC) #1
luoe
lgtm console.assert(false) console.time/timeEnd() console.profile/profileEnd?
3 years, 10 months ago (2017-02-02 07:39:32 UTC) #2
kozy
On 2017/02/02 07:39:32, luoe wrote: > lgtm These methods have own more robust tests: console.assert(false) ...
3 years, 10 months ago (2017-02-02 16:19:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674583002/20001
3 years, 10 months ago (2017-02-02 16:25:54 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-02 16:25:58 UTC) #8
kozy
Alexey, please take a look. I need your comitter lgtm.
3 years, 10 months ago (2017-02-02 17:38:57 UTC) #9
ulan
lgtm
3 years, 10 months ago (2017-02-02 22:38:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674583002/20001
3 years, 10 months ago (2017-02-02 22:39:04 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 23:05:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a62322aadbe3807d923bb7c4f1f930788e8...

Powered by Google App Engine
This is Rietveld 408576698