Chromium Code Reviews| Index: src/inspector/wasm-translation.cc |
| diff --git a/src/inspector/wasm-translation.cc b/src/inspector/wasm-translation.cc |
| index c545b9b6853324de04ee3783820f2a1f45529f22..00f1aabbf64b739df42ae748e28eba741ea33802 100644 |
| --- a/src/inspector/wasm-translation.cc |
| +++ b/src/inspector/wasm-translation.cc |
| @@ -36,6 +36,7 @@ class WasmTranslation::TranslatorImpl { |
| virtual void Init(Isolate*, WasmTranslation*, V8DebuggerAgentImpl*) = 0; |
| virtual void Translate(TransLocation*) = 0; |
| virtual void TranslateBack(TransLocation*) = 0; |
| + virtual ~TranslatorImpl() {} |
| class RawTranslator; |
| class DisassemblingTranslator; |
| @@ -60,7 +61,7 @@ class WasmTranslation::TranslatorImpl::DisassemblingTranslator |
| void Init(Isolate* isolate, WasmTranslation* translation, |
| V8DebuggerAgentImpl* agent) override { |
| // Register fake scripts for each function in this wasm module/script. |
| - Handle<debug::WasmScript> script = script_.Get(isolate); |
| + Local<debug::WasmScript> script = script_.Get(isolate); |
|
dgozman
2017/02/02 17:22:18
How is Handle accessible in this code? Do we inclu
kozy
2017/02/02 17:57:34
I found one suspicious dependency - src/conversion
|
| int num_functions = script->NumFunctions(); |
| int num_imported_functions = script->NumImportedFunctions(); |
| DCHECK_LE(0, num_imported_functions); |